Repository navigation
rebase - #182
Open
tharun-kumarv wants to merge 17 commits into
Open
rebase#182tharun-kumarv wants to merge 17 commits into
tharun-kumarv wants to merge 17 commits into
Conversation
Reason for change: new api implementation Test Procedure: Mentioned in ticket Risks: Low version: minor Signed-off-by: kumar <kumar_Karuppiahyogarajah@comcast.com>
…e-support-for-feed-configuration RDKE-1141: Add override support for feed configuration
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, consistent with existing patterns (e.g., MW_IPK_SERVER_PATH ?=), and does not introduce any functional issues in the current configuration.
Pull request overview
This PR updates the OSS middleware feed configuration to make the IPK server path overridable by downstream configuration, aligning it with the existing middleware include’s default-assignment pattern.
Changes:
- Changed
MW_OSS_IPK_SERVER_PATHfrom a hard assignment (=) to a default/weak assignment (?=) to allow overrides from higher-priority config layers.
File summaries
| File | Description |
|---|---|
| conf/machine/include/oss_mw.inc | Makes MW_OSS_IPK_SERVER_PATH a weak default so downstream builds can override the OSS IPK feed server path. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
RDKEMW-24436: changes for tts getvoices implementation
Signed-off-by: Divyang Abhay Sarangi <divyangabhay_sarangi@comcast.com>
tag for MW 8.7.3.0 Quarterly Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.