Skip to content

Fix missing arguments for known functions in GaPrinter - #603

Open
h55n wants to merge 1 commit into
pygae:masterfrom
h55n:fix/known-function-arguments
Open

h55n wants to merge 1 commit into
pygae:masterfrom
h55n:fix/known-function-arguments

Conversation

@h55n

@h55n h55n commented Nov 16, 2026

Copy link
Copy Markdown

GaPrinter._print_Function drops arguments for known SymPy functions outside its name whitelist, so erf(x) prints as erf.

Keep arguments for known functions while retaining the existing abbreviation for undefined symbolic functions such as f(x). The existing name whitelist stays in place, and LaTeX printing is unchanged.

Adds regressions for erf, gamma, besselj, atan2, and nested undefined functions.

Refs #421. This is the text-printer fix only, not the broader LaTeX changes discussed in #206 and #276.

Tested:

  • Reproduced the failures before the fix; all 13 printer tests pass after it.
  • Full local unit suite: 149 passed, 3 skipped.
  • Full fork CI with notebooks: Python 3.10 and 3.11 each have 583 passed, 3 skipped; Python 3.12 has 584 passed, 2 skipped, including PDF tests. Flake8 passed with the repo's config. https://github.com/h55n/galgebra/actions/runs/43808152670

The fork-only workflow dispatch line is not included here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant