Repository navigation
fix: throw from py::cast instead of returning null with an error set - #6245
Open
kroplabeskidu wants to merge 1 commit into
Open
kroplabeskidu wants to merge 1 commit into
kroplabeskidu wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Item 9 from #6159, related to #4099.
py::castof an unregistered type returns a nullobjectwith aTypeErrorpending, although the docs say a failed cast throws. If the caller doesn't check, the error shows up later:py::castnow throwserror_already_setwhen the caster returns null with an error set. A null result without an error stays as it was, so only the broken case changes. The caster behaviour used for function return values isn't affected, because that path doesn't go throughpy::cast.This covers the missing exception reported in #4099. It doesn't address the ODR violation that caused the failed cast in that report, so I'm not closing the issue here.
Suggested changelog entry:
py::castnow throwserror_already_setwhen the conversion fails with a Python error set, instead of returning a null object.