Repository navigation
Change Bennett refraction algorithm to use apparent elevation - #166
Merged
Merged
Conversation
Updated function parameters and documentation to reflect the use of apparent solar elevation angle instead of true solar elevation angle.
There was a problem hiding this comment.
🟡 Changes recommended
Existing Bennett tests still use the removed elevation keyword and fail with TypeError.
1 open issue
What changed in this PR
Corrects Bennett’s input semantics to use apparent solar elevation, addressing the direction mismatch described in #162 without changing the numerical formula.
Changes:
- Renames the input parameter to
apparent_elevation. - Updates documentation and adds a warning distinguishing Bennett from true-elevation refraction models.
| File | Description |
|---|---|
| src/solposx/refraction/bennett.py | Aligns the parameter, formula notation, and documentation with apparent elevation. |
Review effort: Balanced
Member
|
Can we start a new section here: https://solposx--166.org.readthedocs.build/en/166/refraction.html With brief sentences indicating the direction (true -> apparent vs apparent -> true) |
kandersolar
approved these changes
Oct 21, 2026
kandersolar
left a comment
kandersolar
left a comment
Member
There was a problem hiding this comment.
Needs a what's new entry, but otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162