Repository navigation
fix(examples): set explicit GAUGE and COUNTER types across example configs - #1634
Merged
Merged
Conversation
…nfigs Replace explicit UNTYPED rules and omitted rule types in examples/*.yml and examples/*.yaml with explicit GAUGE or COUNTER types, splitting combined counter/gauge rules where needed. Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
…types Signed-off-by: Bartek Plotka <bwplotka@gmail.com>
dhoard
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes prometheus/jmx_exporter#1623 (cc @dhoard @fstab).
Replaces
type: UNTYPEDand omitted ruletypefields acrossexamples/*.ymlandexamples/*.yamlwith explicitGAUGEandCOUNTERtypes, splitting rules that previously matched both counters and gauges (such asactivemq.yml,kafka-connect.yml,kafka-0-8-2.yml, andkafka-pre0-8-2.yml).Commits:
fix(examples): set explicit GAUGE and COUNTER types across example configstest(collector): verify all example configs declare GAUGE or COUNTER types