Repository navigation
Conversation
Run the volto-light-theme frontend test suite on push and pull request. The workflow checks out the main branch of kitconcept/volto-light-theme and replaces its core folder with the Volto branch that triggered the workflow before installing the dependencies. It then runs lint, Storybook build, i18n checks, and the unit tests. The install uses --no-frozen-lockfile so dependency changes from the Volto branch are resolved correctly.
Member
Author
|
@sneridagh It is necessary to remove the Node 22 jobs from the CI configuration. |
Member
Author
|
@sneridagh I don’t think a failure in this job should block the merge. A failure in VLT tests must not prevent the merging of a Volto PR. |
davisagli
reviewed
Nov 7, 2026
davisagli
left a comment
davisagli
left a comment
Member
There was a problem hiding this comment.
It's a good idea. I think it would be a lot more meaningful to run VLT's acceptance tests rather than just the unit tests, but I'm not sure how long the build would take.
Member
|
@wesleybl @sneridagh I updated the branch protection rules for the main branch to require the Node 26 jobs instead of the Node 22 ones |
Member
|
@davisagli thanks, I was going to do it several times but got sidetracked. |
ericof
approved these changes
Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run the
volto-light-themefrontend test suite on push and pull request. The workflow checks out the main branch of kitconcept/volto-light-theme and replaces its core folder with the Volto branch that triggered the workflow before installing the dependencies.It then runs lint, Storybook build, i18n checks, and the unit tests. The install uses --no-frozen-lockfile so dependency changes from the Volto branch are resolved correctly.