Repository navigation
Fix math.smoothstep and smootherstep when min is greater than max - #9798
Open
zzoraemon043 wants to merge 1 commit into
Open
zzoraemon043 wants to merge 1 commit into
zzoraemon043 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
math.smoothstepandmath.smootherstepreturned early onx <= min/x >= max, which only works whenmin < max. With reversed edges they became an inverted hard step atmin. They now clamp the normalized value to [0, 1] before the polynomial, the same as GLSL, so reversed edges give a falling ramp. Whenmin === maxthe result stays a step (0 at or below, 1 above), as before, instead of dividing by zero. Themin/maxdocs now say which value maps to 0 and 1.Added tests for clamping, reversed edges (including the values from the issue) and equal edges.
Fixes #9767
Checklist