Skip to content

🐛 fix(hero): show the name, copy and navigation with the first paint - #41

Merged
pjborowiecki merged 1 commit into
mainfrom
fix/hero-name-at-first-paint
Nov 16, 2026
Merged

pjborowiecki merged 1 commit into
mainfrom
fix/hero-name-at-first-paint

Conversation

@pjborowiecki

@pjborowiecki pjborowiecki commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Problem

The name, the hero copy and the navigation are in the prerendered page, but each had an entrance animation:

  • Name: hidden as soon as the scripts ran, then raised back over 1.5 s inside a clipped box.
  • Navigation: hidden as the scripts ran, then faded back in.
  • Hero copy: faded in by CSS. Since the copy was restructured, the headline is the third child, so it had the longest delay and appeared after the paragraph beneath it.

Recorded frame by frame on production with a GPU-backed Chromium at 1600×1000, reloading the page:

Production
Name painted at 0.08 s, gone at 0.15 s, back only at 1.87 s
Headline, paragraph, Focus list, navigation links start at 0% opacity, fully visible at 1.17–1.37 s

Change

  • Removes the name rise, the navigation intro tween and the hero copy fade.
  • The hero's name marks are overflow-visible, as the footer's already are, so the scroll dive no longer needs an onUpdate handler to unclip them.
  • Removes data-name-mark, data-word, data-nav-intro and .hero-copy, which only the animations used.

Verification

Measured with the same harness on the test build:

  • Painted frames: the name is in place in every frame from the first.
  • Opacity: the headline, paragraph, Focus list and navigation links stay at 100% in all ~238 frames of a reload.
  • Phone (4× CPU, throttled network): the name is in place from the first frame, cold and warm.
  • Resting layout: the name's geometry is identical to production at 1600×1000, 1280×800 and 390×844.
  • Scroll dive: the share of the screen it floods matches production at every step from 0 to 100% on the same three sizes.

bun run check, bun run test:coverage (213 tests, 100%), bun run build:test and bun run test:e2e:pr (25 specs) pass.

Summary by CodeRabbit

  • Style
    • The name, headline, and navigation now appear on the initial screen without entrance animations.
    • The name remains visible during the initial display; the existing tall-screen scroll animation is preserved.

The name, the hero copy and the navigation are prerendered, but each had
an entrance animation. The name and the navigation were hidden as soon as
the scripts ran, to be animated back, and the copy faded in with the
headline last. Recorded frame by frame on a desktop, the name painted at
0.08 s, vanished at 0.15 s and returned at 1.87 s.

All three entrance animations are gone. The hero's name marks no longer
clip their overflow, so the scroll dive needs no handler to unclip them.
@coderabbitai

coderabbitai Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The landing page no longer applies entrance animations to the hero copy, name mark, or navigation. The hero’s scroll-triggered dive animations remain. NameMark markers and test selectors are updated, and documentation describes the first-screen behavior.

Changes: Landing Page Presentation

Layer / File(s) Summary
Hero copy and name mark
src/presentation/components/custom/landing-page/components/name-mark.tsx, src/presentation/components/custom/landing-page/sections/hero-section.tsx, src/presentation/styles/globals.css, src/presentation/components/custom/__test__/presentation.component.test.tsx, README.md, CHANGELOG.md
The timed name-rise and hero-copy entrance animations are removed. NameMark attributes are removed, SVG overflow is made visible in the specified layouts, and the test and documentation are updated.
Navigation intro animation
src/presentation/components/custom/navigation.tsx
The navigation intro targets, tween configuration, attributes, and GSAP setup are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: Minimal · up to 035ad

The change makes the hero name, copy and navigation visible from first paint by removing entrance animations. No concrete merge-blocking risk was identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title names the main change: the hero name, copy and navigation now show with the first paint. The changeset removes the entrance animations for the name, hero copy and navigation, which matches t…
Description check Passed The description follows the template's main parts. It has a problem statement, a change list, and a verification section that reports test results. It covers the code and test changes. It does not inc…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the hero name, copy and navigation now show with the first paint. The changeset removes the entrance animations for the name, hero copy and navigation, which matches the title. The title also uses a bug-fix emoji and conventional-commit style, which is acceptable.

Full details: Description check

Explanation

The description follows the template's main parts. It has a problem statement, a change list, and a verification section that reports test results. It covers the code and test changes. It does not include the template's Test plan checkboxes or the Docs checklist. The CHANGELOG.md and README updates appear in the raw summary, but the description does not mention them in a checklist. The description is mostly complete, so this is a pass.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3ec71c35-e9c1-43cf-bcd7-ddc1cc8a733e
Commits

Reviewing files that changed from the base of the PR and between 3b884a2 and 035ad29.

Files selected for processing: 7

  • CHANGELOG.md
  • README.md
  • src/presentation/components/custom/__test__/presentation.component.test.tsx
  • src/presentation/components/custom/landing-page/components/name-mark.tsx
  • src/presentation/components/custom/landing-page/sections/hero-section.tsx
  • src/presentation/components/custom/navigation.tsx
  • src/presentation/styles/globals.css
Files with no reviewable changes: 1

  • src/presentation/styles/globals.css

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

@pjborowiecki
pjborowiecki merged commit 5e9d41d into main Nov 16, 2026
10 checks passed
@pjborowiecki
pjborowiecki deleted the fix/hero-name-at-first-paint branch November 16, 2026 00:04
@pjborowiecki pjborowiecki self-assigned this Nov 16, 2026

This branch was successfully deployed

1 active deployment
Preview — 035ad296 Deployed Nov 16, 2026 by pjborowiecki via Deploy preview / Deploy #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant