Repository navigation
Conversation
JustKira
changed the base branch from
feat/tkm-172-doctor-report
to
feat/tkm-175-plugin-pack
November 20, 2026 20:09
Contributor
Author
|
Closing without merging. The plugin shape, the server engine and sign-in are being decided again (Linear TKM-194 and TKM-195), and this work sits on top of them. Nothing is lost: the head commit is 64cdb26, and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Workspace owners can upload a plugin without copying files onto the server.
The raw ZIP body is limited to 50 MiB and the unpacked contents to 200 MiB. Success returns
{"status":"installed|updated|unchanged","id":"…","version":"…","buildId":"…"}. Package errors use the reload error shape,{"error":"…"}withcodefor index backfill failures. The body limit returns HTTP 413. Requests without owner access follow the reload route's authorization rules.The server keeps the current ZIP and dist under
<data>/plugins/<id>/and recovers interrupted replacements on startup. Startup looks at the local index, stored packages, then--plugins, in that order. Uploads that would replace an indexed plugin are refused. Incompatible stored builds remain on disk and show asneeds rebuildinGET /plugins. Public shared-serverGET /healthreturns{"version":"…"}.Two integration tests use HTTP and WebSocket against a real server with temporary storage. They cover installation, unchanged uploads, replacement, refusal and rollback, restart and row retention, and an unrelated plugin whose files change while its old build and action stay live.
Evidence
Before: the server had no package upload route and only loaded its configured installation and index.
After:
cargo test -p server --no-fail-fast -- --test-threads=2—192 passed; 0 failed; 2 ignored(summed across test targets). Plugin integration target:test result: ok. 15 passed; 0 failed; 0 ignored.bash .ci/check.sh rust—test result: ok. 17 passed; 0 failed; 0 ignoredfor the server library.bash .ci/check.sh lint—Tasks: 3 completed.bash .ci/check.sh ts—Tasks: 10 completedfor typecheck,Tasks: 7 completedfor tests and web build, and9 pass / 0 failfor release tests.proto run bun -- test packages/cli/tests—55 pass / 0 fail.Merge Danger
Door: Two-way. The server change adds an endpoint and stores packages beside the database.
Blast Radius: Plugins. The existing reload route keeps its behavior; uploads change only the addressed build. Machine actions, sharing CLI commands, package removal, and window changes are outside this ticket.