Repository navigation
update sveltekit documentation #44739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sacrosanctic
wants to merge
3
commits into
oven-sh:main
Choose a base branch
from
sacrosanctic:patch-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🔎 Supported by static analysis
🏁 Script executed:
sed -n '80,125p' docs/guides/ecosystem/sveltekit.mdxRepository: oven-sh/bun
Length of output: 1152
🌐 Web query:
official Svelte CLI adapter:bun installs svelte-adapter-bun PR 1414💡 Result:
🌐 Web query:
Svelte CLI PR 1414 adapter:bun package install command @sveltejs/adapter-bun svelte-adapter-bun💡 Result:
🏁 Script executed:
Repository: oven-sh/bun
Length of output: 7274
Update the build output for the selected adapter.
The Svelte CLI
adapter:bunmapping installs@sveltejs/adapter-bun, notsvelte-adapter-bun. Replace the retained output with output from the new scaffold and build flow.🤖 Prompt for AI Agents
✅ Addressed in commit e9b401d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clarify bun run. I got the command from the svelte docs. If that is incorrect. Should I correct it upstream as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🤖 web_search executed:
Check official Bun documentation for whether bothbun run --bun buildandbun --bun run buildare valid ways to run a package.json build script with the Bun runtime. Check https://svelte.dev/docs/kit/adapter-bun for its documented build command. Provide source links and exact relevant text.Length of output: 1298
@sacrosancticbun run --bun buildis correct. No upstream correction is needed.The SvelteKit adapter documentation uses that exact command. The
--bunflag makes Vite run with Bun instead of Node.js. The adapter requires Bun because it calls Bun’s build API.bun --bun run buildis also valid.My finding concerns the example build output, not the command. The new scaffold selects
@sveltejs/adapter-bun, but the example still showsUsing svelte-adapter-bun. That output should match the selected adapter. Sorry for the ambiguity.You are interacting with an AI system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sacrosancticThe line indocs/guides/ecosystem/sveltekit.mdxinside the production-build output block:My finding concerns that adapter name, not
bun run --bun build. The command is correct.You are interacting with an AI system.