Repository navigation
validators: resolve UCI installs by exact source path - #122
Open
ZyPulse-zy wants to merge 1 commit into
Open
ZyPulse-zy wants to merge 1 commit into
ZyPulse-zy wants to merge 1 commit into
Conversation
An extensionless rpcd payload and its UCI configuration can share the same basename. Matching all lines containing that basename includes the sibling's conffiles entry and falsely rejects the payload as UCI. Resolve explicit install commands by the package-relative source path, joining continued recipe lines before inspecting their literal package-root destination. Keep the existing fallback when the destination cannot be resolved, and retain validation when a source also installs into etc/config. Reproduces the false positive on openwrt/packages#30800. Add ten regression cases for same-name siblings, continuations, quoting, source boundaries, unknown destinations and config installations. Signed-off-by: Yuen Su <zypulsecore@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UCI check rejects
net/mwan3/files/usr/share/rpcd/ucode/mwan3in openwrt/packages#30800 even though the package installs it to/usr/share/rpcd/ucode/. Its basename also matches the sibling UCI configuration and/etc/config/mwan3conffiles entry.The exact-file guard introduced in #105 still searches by basename, and the real install command puts its destination on a continued line. Match the complete package-relative source token in explicit install/copy commands and join continued recipe lines before inspecting their literal package-root destination. Unknown destinations retain the existing fallback; a source also installed into
/etc/configis still validated.Validation:
wrangler deploy --dry-run.AI assistance was used for implementation and test development.