Skip to content

fix: replace bare except clauses with proper exception handling - #5641

Closed
javascp wants to merge 1 commit into
opendatalab:masterfrom
javascp:fix/bare-except-exception-handling
Closed

javascp wants to merge 1 commit into
opendatalab:masterfrom
javascp:fix/bare-except-exception-handling

Conversation

@javascp

@javascp javascp commented Oct 13, 2026

Copy link
Copy Markdown
  • Replace bare 'except:' with 'except Exception:' in writer.py and operators.py to avoid catching system-level exceptions like KeyboardInterrupt
  • Use specific exceptions (IndexError, ValueError) in rec_postprocess.py where only character index lookup failures are expected

This change improves code robustness and follows Python best practices for exception handling without changing any runtime behavior.

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Please describe the motivation of this PR and the goal you want to achieve through this PR.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

- Replace bare 'except:' with 'except Exception:' in writer.py and operators.py
  to avoid catching system-level exceptions like KeyboardInterrupt
- Use specific exceptions (IndexError, ValueError) in rec_postprocess.py
  where only character index lookup failures are expected

This change improves code robustness and follows Python best practices
for exception handling without changing any runtime behavior.
@github-actions

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@myhloli myhloli closed this Oct 13, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants