Skip to content

fix(realtime): validate beta WebSocket authentication profiles - #4218

Merged
markstuart-oai merged 2 commits into
mainfrom
codex/beta-realtime-provider-preflight
Nov 1, 2026
Merged

markstuart-oai merged 2 commits into
mainfrom
codex/beta-realtime-provider-preflight

Conversation

@markstuart-oai

Copy link
Copy Markdown
Contributor

A bare workload-identity or Bedrock client could attempt a beta Realtime handshake without applying its configured authentication. Reject those unsupported profiles locally before credential refresh or connection, and enforce the documented X.509 WebSocket exclusion.

Preserve explicit Authorization settings for other clients, including default and connection headers, case-insensitive overrides, and removal with omit. Document this compatibility boundary without adding provider token exchange or signing.

Validation:

  • Before the change: 8 refusal cases failed and 16 explicit-header compatibility cases passed.
  • After the change: all 24 profile tests passed.
  • All 74 focused tests passed, including existing beta Azure and redirect controls; the same 74 passed against a locally built, non-editable wheel.
  • Ruff formatting, lint, and diff checks passed.

@markstuart-oai
markstuart-oai requested a review from a team as a code owner October 31, 2026 04:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-31T04:42:26.996045Z a78f9cd PR opened
🔒 Security Review ✅ Completed 2026-10-31T04:43:20.697623Z a78f9cd PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jbeckwith-oai jbeckwith-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact commit 2669ef6. The sync/async beta preflight rejects unsupported implicit provider credentials before connection setup, keeps X.509 blocked, and preserves caller-owned authorization and case-insensitive omission/override behavior. Coordinator and independent static review found no actionable issues. Hosted checks are successful or explicitly skipped. No candidate code or tests executed.

@markstuart-oai
markstuart-oai added this pull request to the merge queue Nov 1, 2026
Merged via the queue into main with commit 3622a97 Nov 1, 2026
26 checks passed
@markstuart-oai
markstuart-oai deleted the codex/beta-realtime-provider-preflight branch November 1, 2026 19:26
@openai-sdks openai-sdks Bot mentioned this pull request Nov 1, 2026
gh-actions-shared Bot pushed a commit to xf-qubit/openai-python that referenced this pull request Nov 1, 2026
Automated Release PR
---


##
[3.42.1](openai/openai-python@v3.42.0...v3.42.1)
(2026-11-01)


### Bug Fixes

* **api:** preserve Responses WebSocket connection behavior
([openai#4221](openai#4221))
([38075d8](openai@38075d8))
* **realtime:** validate beta WebSocket authentication profiles
([openai#4218](openai#4218))
([3622a97](openai@3622a97))


### Refactors

* **websocket:** add SDK-owned Responses policy helpers
([openai#4219](openai#4219))
([83ed269](openai@83ed269))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: openai-sdks[bot] <284451331+openai-sdks[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants