Repository navigation
feat(api): add organization external key management - #4205
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
The public compatibility job's symbol/API comparison passed. Its Pyright phase fails on four bare I will refresh this PR after #4204 lands and rerun the unchanged compatibility gate. No API typing rules or compatibility checks will be disabled for this feature. |
Castiron-Internal-PR: openai/openai-python-internal#373 Castiron-Source-SHA: ef899bcc786b7ad19e016eb01fca52d9b016faae Castiron-Public-Base-SHA: 45b9531
markstuart-oai
left a comment
markstuart-oai
left a comment
There was a problem hiding this comment.
Reviewed all 14 changed files at d82e48d7; no actionable findings. The external-key operations use the existing admin-auth, provider overloads and cursor-page contracts. The added sync/async HTTP tests cover provider bodies, pagination filters and lifecycle response wrappers. Generated ownership and inventory agree.
Validation: complete source review with an independent pass. Hosted runtime tests, build and lint passed; no candidate code ran locally. The compatibility job remains failed: its API comparison passed, then Pyright reported four missing collection type arguments in unchanged tests/test_client.py lines 1123–1124 and 2513–2514. This approval does not waive that check.
d82e48d to
5adcc39
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5adcc393c4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Merged the compatibility prerequisite from #4204 into this branch as 218ffb9. The external-key patch is byte-identical; the comparison base now contains the repaired caller fixtures. Two fresh adversarial review rounds are clean, all 10 external-key contracts and 3 compatibility-routing cases pass, and Ruff/ty pass. CI is rerunning; requested owner approval on this exact head. |
Summary
Add organization external-key registration and validation for AWS, GCP and Azure.
Changes