Repository navigation
Conversation
run.py records a score for a dataset only when evaluate() returns a dict or a DataFrame; an implicit None is reported as skip_reason='evaluate_returned_none' in status.json, so these benchmarks ran to completion yet contributed nothing to the summary (issue open-compass#1690). - olmOCRBench: evaluator() now returns the overall / per-JSONL scores and evaluate() forwards them to run.py - DUDE, SlideVQA, MMLongBench-Doc: return the accuracy table that *_acc() already computes and dumps - MATBench: mat_evaluate() returns the mean metrics dict - OceanOCRBench: oceanocr_evaluate() returns the ZH / EN / scene averages Adds tests/test_evaluate_returns_summary.py, which pins the return contract (fails on upstream, passes with this change). Signed-off-by: li-lizhe <147392333@qq.com>
Author
|
Gentle ping on this one — it's been quiet for 8 days since the last activity, so I wanted to check whether there's anything else you'd like me to adjust or add before this can move forward. Happy to make changes if so. Thanks! |
Author
|
@ssiq — would one of you be able to take a look at this when you get a chance?
Happy to adjust if the approach doesn't fit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
run.pyrecords a score for a dataset only whendataset.evaluate()returns adictor apandas.DataFrame; anything else is logged asskip_reason='evaluate_returned_none'instatus.json.Several datasets compute their summary, write it next to the prediction file and then discard it, so a
benchmark that ran to completion reports nothing at all (issue #1690).
This PR returns the summaries so the numbers reach
status.json/ the summary scripts:evaluator()returnsNone{'overall': ..., '<jsonl category>': ...}return DUDE_acc(storage)return SlideVQA_acc(storage)return MMLongBench_acc(storage)mat_evaluate()returns the metric dictoceanocr_evaluate()returns theZH_/EN_/scene_averagesVerification
Added
tests/test_evaluate_returns_summary.py(stub-based, in the style oftests/test_logicvista.py,so it needs neither the datasets nor a judge model):
Not tested: no full end-to-end benchmark run (olmOCRBench / DUDE / SlideVQA / MMLongBench-Doc /
MATBench / OceanOCRBench need their datasets and a judge model). The patch only plumbs back the object
that is already written to the
*_score.csv/*_eval_summary.csvfiles; the returned values areplain
floats built from those rows, andflatten_summary_metricsalready handles bothdictandDataFrame.Fixes #1690