Skip to content

fix(ipx): import NitroRuntimeConfig from nitropack/types - #2354

Merged
danielroe merged 1 commit into
nuxt:mainfrom
luc122c:fix/ipx-legacy-nitro-runtime-config-type
Oct 19, 2026
Merged

danielroe merged 1 commit into
nuxt:mainfrom
luc122c:fix/ipx-legacy-nitro-runtime-config-type

Conversation

@luc122c

@luc122c luc122c commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

📚 Description

Fixes a ts(6385) deprecation in the Nitro v2 IPX handler.

src/runtime/server/routes/_ipx.legacy.ts imported NitroRuntimeConfig from the bare nitropack entry, which is marked as deprecated. This PR imports the type from nitropack/types instead, which is where the non-deprecated declaration lives.

The bare `nitropack` entry re-exports a deprecated NitroRuntimeConfig. Import the type from the `nitropack/types` subpath in the legacy IPX handler instead.
@luc122c
luc122c requested a review from danielroe as a code owner October 17, 2026 23:20
@pkg-pr-new

pkg-pr-new Bot commented Oct 17, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2354

commit: e7993b9

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.62%. Comparing base (638a7b8) to head (e7993b9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2354   +/-   ##
=======================================
  Coverage   32.62%   32.62%           
=======================================
  Files           9        9           
  Lines         377      377           
  Branches      133      133           
=======================================
  Hits          123      123           
  Misses        197      197           
  Partials       57       57           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 70a7bc16-db88-4aaf-8b7b-040f18b629cf
📥 Commits

Reviewing files that changed from the base of the PR and between 638a7b8 and e7993b9.

📒 Files selected for processing: 1
  • src/runtime/server/routes/_ipx.legacy.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The legacy IPX route now imports NitroRuntimeConfig from nitropack/types instead of nitropack. Runtime behavior is unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to e7993

This type-only import change does not alter runtime behavior, and the declared Nitro version exposes the imported type. No merge-blocking risk is identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description check Passed The description clearly explains the deprecation fix and identifies the affected import and file.
Title check Passed The title is concise, specific, and accurately describes the import change. It follows the conventional commit format.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@danielroe
danielroe added this pull request to the merge queue Oct 19, 2026
Merged via the queue into nuxt:main with commit 8729b2e Oct 19, 2026
13 checks passed
@luc122c
luc122c deleted the fix/ipx-legacy-nitro-runtime-config-type branch October 19, 2026 17:39
@github-actions github-actions Bot mentioned this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants