Repository navigation
CI: add smoke test for spin bench - #161
Open
InessaPawson wants to merge 3 commits into
Open
InessaPawson wants to merge 3 commits into
InessaPawson wants to merge 3 commits into
Conversation
Member
Author
|
According to CI, the smoke test passes on Linux and macOS, but Windows fails at Should I push a diagnostic commit to check |
seberg
reviewed
Oct 12, 2026
seberg
approved these changes
Oct 13, 2026
Member
|
Hmmmmm, I am really not sure why the asv command fails on that that one (or two) windows job when it works on the 3.15 one? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #159. Nothing in CI exercised
spin bench, so a future incompatibility with spin or asv would go unnoticed. This adds a step after the test suite that registers the machine with asv and runs a single benchmark (Npv2D.time_broadcast) in dry-run mode.I verified the step locally on macOS (Tahoe 26.5.2). I’d suggest checking the Windows/Linux runs as well.