Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default binary ANSYS writer raises
KeyError: dtype('uint64')for unsigned mesh connectivity, as reported in #1335. This affects supported triangle/tetra cells produced by tools such as pygmsh.Convert unsigned connectivity into a fresh native int64 array before selecting the existing signed64 binary section. Check that the one-based node IDs fit first, avoiding narrowing or wraparound. Signed and ASCII paths stay unchanged, and input arrays are not modified.
Validation on Python 3.12 / NumPy 2.5.4, macOS arm64:
This addresses the dtype defect for existing ANSYS-supported cells. The unfiltered example in #1335 also contains already-unsupported vertex/line cells; this change does not add those. Solver import, other platform matrices and hosted CI were not tested locally.
Implementation and independent local review were performed by separate Codex agents.