Repository navigation
Update Grengine to 3.1.2 (group ID and package ch.grengine) - #7842
Merged
Merged
Conversation
Signed-off-by: Alain Stalder <astalder@xphi.ch>
✅ Deploy Preview for nextflow-docs canceled.
|
pditommaso
approved these changes
Oct 18, 2026
pditommaso
left a comment
Member
There was a problem hiding this comment.
Hi! Thanks a lot, very appreciated
Signed-off-by: Alain Stalder <astalder@xphi.ch>
alainstalder
force-pushed
the
grengine-3.1.1
branch
from
October 18, 2026 12:24
e9b826a to
936ccc5
Compare
Contributor
Author
|
@pditommaso Sorry for the force push right after your approval: it only added the missing DCO sign-off to the last commit. CI workflows would need approval again it seems... |
Member
|
No pb! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm the author of Grengine. I recently found out that Nextflow uses it, which I'm very glad to see!
As of version 3.1.0 (September 2024), Grengine moved back from
ch.artecat.grenginetoch.grengine, both as the Maven group ID and as the Java package. Nextflow is still onch.artecat.grengine:grengine:3.0.2. Sorry for the inconvenience of that move; had I known that Nextflow used Grengine, I would have thought twice about it.This PR updates Nextflow to the new
ch.grengine:grengine:3.1.2:modules/nextflow/build.gradle:ch.artecat.grengine:grengine:3.0.2→ch.grengine:grengine:3.1.2. Theexclude group: 'org.codehaus.groovy'is dropped because the published POM of Grengine 3.1.2 has no Groovy dependency.import ch.artecat.grengine.Grengine→import ch.grengine.Grenginein 7 files (5 main, 2 test).Apart from the package name, the API of 3.1.2 is identical to 3.0.2's. The changes since then are all related to Grape and publishing, so they probably don't matter for Nextflow:
@Grabwith the Maven Grape engine of Groovy 6 (3.1.2).Grengine 3.1.2 is tested with Groovy 2.5 to 6 on Java 8 to 25.
For the old coordinates, I've published a relocation POM
ch.artecat.grengine:grengine:3.1.1→ch.grengine:grengine:3.1.1. Dependabot or Renovate may therefore propose that version, which would not compile because of the package change. This PR is the proper way to update.Tested locally: the build succeeds and
TaskRunTestandTaskDirectiveReadsTest, which use Grengine directly, pass.If anything comes up, just ping me here.
Links: grengine.ch, GitHub, release notes
Comment:
Updated to Grengine 3.1.2, released today: its published POM no longer declares a runtime dependency on Groovy (which had slipped in with 3.1.0), and it adds a workaround for GROOVY-12458. Title and description are updated accordingly.
(the branch name is grengine-3.1.1, but meant is now 3.1.2)