Skip to content

[client] Mark Rosenpass as deprecated (backport #8372 to 0.82) - #8407

Merged
riccardomanfrin merged 1 commit into
release-0.82from
cherry_pick_rosenpass_deprecation_0_82
Oct 28, 2026
Merged

riccardomanfrin merged 1 commit into
release-0.82from
cherry_pick_rosenpass_deprecation_0_82

Conversation

@riccardomanfrin

@riccardomanfrin riccardomanfrin commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes

Backport of #8372 to release-0.82, so the Rosenpass deprecation notice ships with v0.82.0. Clean cherry-pick (git cherry-pick -x 36339993b), no conflicts.

Issue ticket number and link

Original PR: #8372. Agreed in the internal engineering sync on 2026-10-26; no public issue.

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)
  • I ran and tested this change locally — I did not rely on CI to find out whether it works
  • This PR has a single purpose (not a fix + refactor + feature in one)
  • This change is a trivial fix, OR it links an issue the NetBird team agreed on beforehand. Changes to the public API, gRPC protocols, functionality behavior, CLI / service flags, or new features always need that agreement first. See CONTRIBUTING.md.

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

netbirdio/docs#1069

View guided diff Turn on auto-fix

* [client] Mark Rosenpass flags as deprecated

Rosenpass support is being deprecated. Users enabling it from the CLI
should learn that before they depend on it, while the feature itself
keeps working.

* [client] Show Rosenpass deprecation notice in the UI settings

Desktop users enable Rosenpass from the settings toggle, not the CLI,
so the deprecation notice needs to reach them there too. A new string
key falls back to English until Crowdin translates it, instead of
showing a stale translation without the notice.

* [client] Keep switchOrCreateProfile doc comment attached

The Rosenpass warning helper landed between switchOrCreateProfile and
its doc comment, leaving the function undocumented.

* [client] Use MarkDeprecated for the Rosenpass flags

Follows the convention already used for --enable-lazy-connection, as
asked in review. The flags drop out of --help and pflag warns on any
use, so the custom helper is no longer needed.

* [client] Isolate the Rosenpass flag test from upCmd's flag set

Setting the shared upCmd flags left them marked Changed for any later
test in the package.

(cherry picked from commit 3633999)

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@riccardomanfrin
riccardomanfrin merged commit 6ab0ffe into release-0.82 Oct 28, 2026
39 checks passed
@riccardomanfrin
riccardomanfrin deleted the cherry_pick_rosenpass_deprecation_0_82 branch October 28, 2026 15:58
@github-actions

Copy link
Copy Markdown

@tilltmk

tilltmk commented Nov 5, 2026

Copy link
Copy Markdown

why on earth ditch rosenpass?!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants