Repository navigation
[client] Mark Rosenpass as deprecated (backport #8372 to 0.82) - #8407
Conversation
* [client] Mark Rosenpass flags as deprecated Rosenpass support is being deprecated. Users enabling it from the CLI should learn that before they depend on it, while the feature itself keeps working. * [client] Show Rosenpass deprecation notice in the UI settings Desktop users enable Rosenpass from the settings toggle, not the CLI, so the deprecation notice needs to reach them there too. A new string key falls back to English until Crowdin translates it, instead of showing a stale translation without the notice. * [client] Keep switchOrCreateProfile doc comment attached The Rosenpass warning helper landed between switchOrCreateProfile and its doc comment, leaving the function undocumented. * [client] Use MarkDeprecated for the Rosenpass flags Follows the convention already used for --enable-lazy-connection, as asked in review. The flags drop out of --help and pflag warns on any use, so the custom helper is no longer needed. * [client] Isolate the Rosenpass flag test from upCmd's flag set Setting the shared upCmd flags left them marked Changed for any later test in the package. (cherry picked from commit 3633999)
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
|
Release artifactsBuilt for PR head
GHCR images (amd64)
This comment is updated by the Release workflow. Artifact links expire according to the workflow retention policy. |
|
why on earth ditch rosenpass?! |



Describe your changes
Backport of #8372 to
release-0.82, so the Rosenpass deprecation notice ships with v0.82.0. Clean cherry-pick (git cherry-pick -x 36339993b), no conflicts.Issue ticket number and link
Original PR: #8372. Agreed in the internal engineering sync on 2026-10-26; no public issue.
Stack
Checklist
Documentation
Select exactly one:
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
netbirdio/docs#1069