Repository navigation
[client] Mark Rosenpass as deprecated #8372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a139faa
[client] Mark Rosenpass flags as deprecated
riccardomanfrin 7c06cd0
[client] Show Rosenpass deprecation notice in the UI settings
riccardomanfrin b06ebaa
[client] Keep switchOrCreateProfile doc comment attached
riccardomanfrin f23fdc2
[client] Use MarkDeprecated for the Rosenpass flags
riccardomanfrin 08dd71b
[client] Isolate the Rosenpass flag test from upCmd's flag set
riccardomanfrin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package cmd | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "testing" | ||
|
|
||
| "github.com/spf13/pflag" | ||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestRosenpassFlagsWarnDeprecated(t *testing.T) { | ||
| origEnabled, origPermissive := rosenpassEnabled, rosenpassPermissive | ||
| t.Cleanup(func() { | ||
| rosenpassEnabled, rosenpassPermissive = origEnabled, origPermissive | ||
| }) | ||
|
|
||
| for _, name := range []string{enableRosenpassFlag, rosenpassPermissiveFlag} { | ||
| // Copy the production flag into a private set so Set marks only the copy as | ||
| // Changed, leaving upCmd's shared flag set untouched for other tests. | ||
| prod := upCmd.PersistentFlags().Lookup(name) | ||
| require.NotNil(t, prod, "flag --%s must be registered on up", name) | ||
| flagCopy := *prod | ||
|
|
||
| var out bytes.Buffer | ||
| flags := pflag.NewFlagSet("rosenpass-test", pflag.ContinueOnError) | ||
| flags.SetOutput(&out) | ||
| flags.AddFlag(&flagCopy) | ||
|
|
||
| require.NoError(t, flags.Set(name, "true")) | ||
|
cubic-dev-ai[bot] marked this conversation as resolved.
Resolved
riccardomanfrin marked this conversation as resolved.
Resolved
|
||
| assert.Contains(t, out.String(), "Flag --"+name+" has been deprecated", "setting --%s should print the deprecation notice", name) | ||
| assert.False(t, prod.Changed, "the shared --%s flag must stay unchanged", name) | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.