Repository navigation
feat(netbird): expose the relay QUIC listener - #76
Open
codechirag5610 wants to merge 1 commit into
Open
codechirag5610 wants to merge 1 commit into
codechirag5610 wants to merge 1 commit into
Conversation
The relay binds QUIC to its WebSocket port over UDP, but the chart's Service carried only the TCP port, so peers could never reach it. backend.split.relay.service.quic.enabled adds the UDP port to the Service and the matching container port. The relay starts the QUIC listener only when it terminates TLS itself, so the render fails when neither config.tls nor config.letsencrypt.domains is set, rather than publishing a port nothing listens on. Closes netbirdio#21
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Author
|
Ran the repository's own e2e suite against this branch, since the workflows here are waiting on approval: Real peers connected through the chart as usual, and the suite cleaned up after itself. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #21.
Problem
The relay binds a QUIC listener to the same address as its WebSocket listener, over UDP (
newListeners). The chart's relay Service carries only the TCP port, so peers can never reach QUIC — the issue's "chart exports only http port for WebSocket".The listener is conditional upstream:
ServerQUICTLSConfigneeds a TLS config, so the relay starts QUIC only when it terminates TLS itself. Behind a TLS-terminating proxy it logsNot starting QUIC listenerand serves WebSocket alone.Change
backend.split.relay.service.quic.enabled(defaultfalse) adds aquicUDP port to the relay Service onservice.port, plus the matching container port. Because the exposure is only useful when the relay really listens, the render fails when QUIC is enabled withoutconfig.tlsorconfig.letsencrypt.domains, rather than publishing a port nothing is bound to.A Service carrying TCP and UDP on one port needs Kubernetes 1.26+ for
LoadBalancer.Tests
render.shcheck 24: no UDP port by default; enabling QUIC without relay TLS fails the render; with TLS the Service getsname: quic/protocol: UDPon the WebSocket port and the deployment gets the UDP container port.helm lint --strict, bothrender.shsuites, all seven example renders and kubeconform pass.config.tlsset, the relay logs both listeners on one port:Not starting QUIC listener: valid TLS config is required for QUIC listener, which is what the guard prevents you from shipping a dead UDP port into. The API server accepted the mixed-protocol Service as bothClusterIPandLoadBalancer.