Skip to content

Keep pending clip and fill-rule state out of pattern tiles - #22286

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:pattern_fill_pending_state
Oct 21, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:pattern_fill_pending_state

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for e2debff (run, references from mozilla/pdf.js.refs@bc15d0333a).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1403 11m 20s 0 1 0 1 view differences
Windows ⚠️ 1403 14m 48s 0 0 0 1

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (03c06f7) to head (e2debff).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22286      +/-   ##
==========================================
- Coverage   90.45%   90.43%   -0.03%     
==========================================
  Files         277      277              
  Lines       68279    68282       +3     
==========================================
- Hits        61764    61751      -13     
- Misses       6515     6531      +16     
Flag Coverage Δ
browsertest 66.29% <100.00%> (-0.02%) ⬇️
fonttest 8.98% <ø> (ø)
integrationtest 69.44% <100.00%> (+<0.01%) ⬆️
unittest 60.85% <100.00%> (+<0.01%) ⬆️
unittestcli 58.60% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@codspeed

codspeed Bot commented Oct 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing calixteman:pattern_fill_pending_state (e2debff) with master (03c06f7)

Open in CodSpeed

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@calixteman
calixteman merged commit f17d348 into mozilla:master Oct 21, 2026
32 checks passed
@calixteman
calixteman deleted the pattern_fill_pending_state branch October 21, 2026 15:30
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026

This branch was successfully deployed

1 active deployment
sync_pdfs — e2debff7 Deployed Oct 21, 2026 by calixteman via request #540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants