Skip to content

Fix Type3 text advances - #22285

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:type3_advance
Oct 21, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:type3_advance

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Advance invisible text. Keep character and word spacing independent of the font-size sign. Exclude font matrix translation from glyph advances.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 2a3ede6 (run, references from mozilla/pdf.js.refs@bc15d0333a).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1403 10m 58s 0 1 0 1 view differences
Windows ⚠️ 1403 16m 52s 0 0 0 1

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.46%. Comparing base (f17d348) to head (4ee5938).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22285      +/-   ##
==========================================
+ Coverage   90.45%   90.46%   +0.01%     
==========================================
  Files         277      277              
  Lines       68282    68280       -2     
==========================================
+ Hits        61766    61772       +6     
+ Misses       6516     6508       -8     
Flag Coverage Δ
browsertest 66.36% <100.00%> (+<0.01%) ⬆️
fonttest 8.98% <ø> (ø)
unittest 60.85% <75.00%> (+<0.01%) ⬆️
unittestcli 58.58% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@codspeed

codspeed Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing calixteman:type3_advance (4ee5938) with master (f17d348)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (4ee5938) during the generation of this report, so f17d348 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

Comment thread src/display/canvas.js Outdated
Advance invisible text. Keep character and word spacing independent of
the font-size sign. Exclude font matrix translation from glyph advances.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@calixteman
calixteman merged commit 439f5ee into mozilla:master Oct 21, 2026
23 checks passed
@calixteman
calixteman deleted the type3_advance branch October 21, 2026 15:54
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants