Repository navigation
Fix stale references in comments and docs - #33
Merged
Merged
Conversation
- pty.mbt pointed at a repro/ directory that is not in the repo - pty_win32_resolve.mbt pointed at a README section that moved to docs/internals.md - pty_unix.mbt named a resolve_path helper that no longer exists - AGENTS.md still said moon.mod.json - docs/internals.md said posix_openpt; pty.c opens /dev/ptmx directly - the README example wrote to the pty after read_all had hit EOF Comments and docs only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comments and docs only; no code or
.mbtichange.pty.mbtpointed at arepro/directory that is not in the repo — now points atdocs/invariants.mdandpty_wbtest.mbt.pty_win32_resolve.mbtpointed at a README section that moved todocs/internals.md.pty_unix.mbtnamed aresolve_pathhelper that no longer exists.AGENTS.mdstill saidmoon.mod.json; the repo usesmoon.mod.docs/internals.mdsaidposix_openpt;pty.copens/dev/ptmxdirectly.read_allhad already hit EOF; it now spawns an interactivesh, writes (includingexit), then reads.Ran locally on macOS:
moon check --deny-warn,moon fmt --check,moon info,moon test(21 passed). The one win32 file touched changes a comment only.Independent of the empty-
PATHfix PR; the two touch different hunks and merge cleanly in either order.🤖 Generated with Claude Code