Skip to content

LXR: Further changes about nonmoving in LXR #1622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qinsoon merged 1 commit into from
Oct 27, 2026
Merged

LXR: Further changes about nonmoving in LXR #1622

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/plan/lxr/global.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ pub static LXR_CONSTRAINTS: Lazy<PlanConstraints> = Lazy::new(|| PlanConstraints

impl<VM: VMBinding> Plan for LXR<VM> {
fn current_gc_may_move_object(&self) -> bool {
true
LXR_CONSTRAINTS.moves_objects
}

fn collection_required(&self, space_full: bool, _space: Option<SpaceStats<Self::VM>>) -> bool {
Expand Down Expand Up @@ -420,9 +420,14 @@ impl<VM: VMBinding> ConcurrentPlan for LXR<VM> {

impl<VM: VMBinding> LXR<VM> {
pub fn new(args: CreateGeneralPlanArgs<VM>) -> Box<Self> {
// Only evacuation forwards objects, so a build without evacuation can keep the
// forwarding bits on the side.
// TODO: LXR should be able to use side forwarding bits -- it needs to make sure side
// forwarding bits are cleared properly for dead/forwarded objects.
assert!(
VM::VMObjectModel::LOCAL_FORWARDING_BITS_SPEC.is_in_header(),
"LXR does not support placing forwarding bits on the side."
VM::VMObjectModel::LOCAL_FORWARDING_BITS_SPEC.is_in_header()
|| !LXR_CONSTRAINTS.moves_objects,
"LXR does not support placing forwarding bits on the side unless evacuation is disabled."
);
let num_workers = args.scheduler.num_workers();
#[allow(unused_mut)]
Expand Down
Loading