Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old constant
MAX_SPACES = 16made space index calculation complicated. We fix this by defining the number of bits in the space index (SPACE_INDEX_BITS), then deriveSPACE_INDEX_LIMITwhich is the limit of (strictly greater than) valid space indices, andMAX_SPACESwhich is the max valid space indices. NowMAX_SPACESis 15 which is the highest value that can be represented with 4 bits.We modified
SFTSpaceMapso thatSFTSpaceMap::sftnow has exactlySPACE_INDEX_LIMITelements instead of deriving the length fromAddress::MAX.addr_to_indexnow returnsOption<usize>and returnsNoneif an address cannot be mapped to a valid space index.