Repository navigation
fix(deps): update filelock, setuptools, and virtualenv for security fixes - #546
Merged
arekay-nv merged 1 commit intoOct 26, 2026
Conversation
…ixes pip-audit now reports five advisories against packages that main already locks, so every PR's audit job fails: - filelock 3.25.2 -> 4.2.4 (CVE-2026-112907, CVE-2026-112913, CVE-2026-112940; fixed in 4.2.1) - setuptools 83.0.0 -> 84.2.1 (GHSA-xmj3-9gf7-h52w; fixed in 84.1.0) - virtualenv 21.14.9 -> 21.14.10 (CVE-2026-113713) Raise the dev-extra filelock floor and virtualenv pin, and the setuptools floor in [tool.uv] constraint-dependencies. The bfcl fork keeps its own filelock 3.20.0 pin, as before. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage ? 81.37%
=======================================
Files ? 157
Lines ? 22472
Branches ? 0
=======================================
Hits ? 18286
Misses ? 4186
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the
auditjob failure seen on #491. pip-audit now reports fiveadvisories against packages that
mainalready locks, so every PR'sauditjob fails until they are fixed.
main's lastauditrun (2026-10-22) passedwith the same lock; the advisories were published afterwards.
devfloor, plus torch, huggingface-hub, datasets, virtualenvdevpin, plus pre-commitOriginal failure: https://github.com/mlcommons/endpoints/actions/runs/40120902824/job/120952010489
Changes
pyproject.toml: raises thedevfloorfilelock>=4.2.1, thedevpinvirtualenv==21.14.10, and the[tool.uv] constraint-dependenciesfloorsetuptools>=84.1.0. The CVE comments list the new advisories.uv.lock: relocked with--upgrade-packagefor the three packages. Theirversions are the only changes. Five other records change only to reference
the new filelock version. No packages are added or removed. The
bfclforkkeeps its own
filelock==3.20.0, as before.filelock 4 (major version)
This repo doesn't import filelock. Its dependents import
FileLock,SoftFileLock,BaseFileLock,UnixFileLockandTimeout; all areunchanged in 4.x. The 4.0 breaking change is the on-disk protocol of
SoftReadWriteLock, which none of them use. virtualenv 21.14.10 acceptsfilelock<5.Type of change
Testing
uv run pip-audit --ignore-vuln PYSEC-2026-3740: no knownvulnerabilities, one existing ignore (Remove pip-audit ignore for nltk PYSEC-2026-3740 once a fixed release ships #520).
uv pip check: all 143 installed packages compatible.uv lock --checkwith local uv 0.12.10, CI-era uv 0.12.23 and the latestuv, 0.13.5.
-m "not slow and not performance") on macOS:2599 passed, 55 failed. All 55 are macOS-only: CPU affinity requires
Linux (
pin_loadgen() requires Linux, noos.sched_getaffinity). Thesame 55 tests fail with
main's filelock/setuptools/virtualenvinstalled, so the bump changes no results.
uv run pre-commit run --all-files: all hooks pass except the threeknown macOS-only mypy errors for
sched_setaffinity/sched_getaffinityin unchanged source.git diff --check.Checklist
🤖 Generated with Claude Code