Skip to content

test(types): point the example fixtures at learn.openapis.org's new paths - #242

Merged
dinwwwh merged 3 commits into
mainfrom
claude/project-thread-oxo0do
Oct 31, 2026
Merged

dinwwwh merged 3 commits into
mainfrom
claude/project-thread-oxo0do

Conversation

@dinwwwh

@dinwwwh dinwwwh commented Oct 31, 2026

Copy link
Copy Markdown
Member

Requested by dinwwwh · project thread

Found in the types package issue hunt.

learn.openapis.org moved its example documents into examples/v3.0/, examples/v3.1/ and examples/v3.2/ (the 3.2 ones are now v3.2/3.2-query-example.json and v3.2/3.2-tags-example.json). Because of that, the // Generated from links at the top of all 11 files in packages/types/tests/examples/ returned 404. That makes the fixtures harder to regenerate, which their headers ask for.

I fetched every document from its new path and deep-compared it with the fixture's doc. All 11 are identical, so only the link comments change. The learn site's examples index lists the same 11 documents, so no new example is missing.

The schema-tests-3.1/ and schema-tests-3.2/ fixtures were checked the same way against their v3.1-dev and v3.2-dev sources: their links work and their contents match.


Generated by Claude Code

…only adds fields

3.1's Discriminator Object is the 3.0 one plus specification extensions,
and 3.2's API key, mutual TLS and OpenID Connect schemes and OAuth Flows
Object are the 3.1 ones plus `deprecated` or `deviceAuthorization`. They
now extend the earlier type instead of repeating its fields and JSDoc.
Every export stays equivalent to before (mutual assignability and the
same keys, checked for all 141 exports).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VVaw7Scg1GzNV1L1jRVWNL
…aths

learn.openapis.org moved its examples into v3.0/, v3.1/ and v3.2/
folders, so the "Generated from" links in the 11 example fixtures went
to 404. The documents at the new paths are identical to the fixtures,
so only the links change.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VVaw7Scg1GzNV1L1jRVWNL
@dinwwwh dinwwwh self-assigned this Oct 31, 2026
@codecov

codecov Bot commented Oct 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No new issues found.

Reviewed changes

  • Fixture link comments realigned to upstream paths — the // Generated from header in all 11 files under packages/types/tests/examples/ now points at learn.openapis.org's versioned examples/v3.0|v3.1|v3.2/ directories. Only the comment line changes; every fixture's doc payload is untouched, so there is no behavioral surface.

I verified all 11 new URLs against the live upstream directory listings: the six v3.0 files (api-with-examples, callback-example, link-example, petstore, petstore-expanded, uspto), the three v3.1 files (non-oauth-scopes, tictactoe, webhook-example), and the two v3.2 files (3.2-query-example, 3.2-tags-example) all resolve. The upstream naming is inconsistent — v3.0/v3.1 drop the version suffix while v3.2 keeps its prefix — and the patch correctly matches that quirk rather than normalizing it.

Pullfrog  | View workflow run | Using deepseek-v4.1-flash (free via Pullfrog for OSS) | 𝕏

@codspeed

codspeed Bot commented Oct 31, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

1 warning

⚠️ 1 benchmark is dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 29 untouched benchmarks
⏩ 2 skipped benchmarks1


Comparing claude/project-thread-oxo0do (2b22fca) with main (3cbcc19)

Open in CodSpeed

Footnotes

  1. 2 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@dinwwwh
dinwwwh merged commit e1af7bb into main Oct 31, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants