Repository navigation
Test PowerPoint missing text with real fixtures and shared vectors - #2594
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The tests accurately exercise the intended real-file edge cases across structural, library, and CLI paths.
Review effort: Balanced
Findings: None
What changed in this PR
Updates PowerPoint regression tests to use real presentations and shared conversion vectors instead of fabricated None values.
Changes:
- Adds reproducible fixtures for empty text runs and missing notes frames.
- Validates fixture structure in dedicated PowerPoint tests.
- Shares content-preservation assertions across library and CLI tests.
| File | Description |
|---|---|
packages/markitdown/tests/test_pptx.py |
Adds structural fixture and notes-heading checks. |
packages/markitdown/tests/_test_vectors.py |
Adds shared conversion expectations for four regressions. |
packages/markitdown/tests/test_files/generate_pptx_missing_text_fixtures.py |
Rebuilds the regression fixtures. |
packages/markitdown/tests/test_files/pptx_empty_title_run.pptx |
Covers an empty title run. |
packages/markitdown/tests/test_files/pptx_empty_body_run.pptx |
Covers an empty body run. |
packages/markitdown/tests/test_files/pptx_notes_empty_run.pptx |
Covers an empty notes run. |
packages/markitdown/tests/test_files/pptx_notes_missing_body_frame.pptx |
Covers an absent notes body frame. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+75
to
+79
| FileTestVector( | ||
| filename="pptx_empty_title_run.pptx", | ||
| mimetype="application/vnd.openxmlformats-officedocument.presentationml.presentation", | ||
| charset=None, | ||
| url=None, |
This was referenced Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The missing-text PowerPoint regressions previously replaced library properties with fabricated None values and only asserted that conversion returned non-None output. They now convert real saved presentations and verify that surrounding content survives through the shared library and CLI vectors.
An empty <a:t/> is normalized to an empty string by python-pptx; it does not produce None shape text. The missing notes-body fixture exercises a genuinely absent notes text frame.
Validation: 49 PowerPoint tests passed before vector consolidation; after consolidation, 40 targeted vector/structural cases passed and 8 remote cases were skipped. Changed Python files formatted with Black 23.7.0; git diff --check passed.