Repository navigation
Exclude hidden worksheets by default in XLSX conversion - #2563
Open
Siddlab (SiddarthaK16) wants to merge 2 commits into
Open
Siddlab (SiddarthaK16) wants to merge 2 commits into
Siddlab (SiddarthaK16) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Umesh Patel (UmeshCode1)
left a comment
There was a problem hiding this comment.
Very clean implementation and well-aligned with #1073.
A few notable positive aspects of this design:
- Stream Hygiene: In
_get_visible_sheet_names, opening withread_only=Trueavoids loading entire cell matrices just to inspect sheet visibility metadata, and ensuringworkbook.close()+file_stream.seek(start_pos)insidefinallyprevents stream pointer corruption for downstream converters or repair passes. - Empty Edge-Case Safety: The
if not sheet_names: return {}guard cleanly avoidspd.read_excelthrowing when passed an empty list if a workbook has all sheets marked hidden. - CLI & Python Option Symmetry: Passing
**conversion_optionsto bothconvert()andconvert_stream()keeps CLI and programmatic usage uniform. - Test Coverage: Explicitly asserting both
hiddenandveryHiddensheets in the test suite verifies the complete OpenXML visibility spec.
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1073.
PR #2456 also addresses hidden worksheets, but keeps them included by default for compatibility. This PR follows issue #1073's request for visible-only output by default, with an explicit opt-in for the previous behavior.