Repository navigation
fix: buffer CLI stdin before format detection on Windows - #2351
Merged
Adam Fourney (afourney) merged 5 commits intoSep 2, 2026
Merged
Conversation
Contributor
Author
@microsoft-github-policy-service agree [company="{your company}"] |
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The Windows stdin failure is addressed with appropriate regression coverage; only a minor duplicate import remains.
Pull request overview
Buffers CLI stdin before conversion to ensure reliable format detection and rewinding on Windows.
Changes:
- Buffers stdin using
BytesIO. - Corrects stdin test execution and adds a Windows pipe regression test.
- Uses the active interpreter and explicit UTF-8 file decoding.
File summaries
| File | Description |
|---|---|
packages/markitdown/src/markitdown/__main__.py |
Buffers stdin before conversion. |
packages/markitdown/tests/test_cli_misc.py |
Adds Windows pipe regression coverage. |
packages/markitdown/tests/test_cli_vectors.py |
Corrects stdin and subprocess test behavior. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1209
What changed
BytesIObefore conversion so format probing can rewind it on WindowsRoot cause
On Windows, pipe-backed
sys.stdin.buffercan reportseekable() == Trueeven thoughseek(0)does not rewind it. Magika consumes the pipe during format detection, leaving the converter at EOF. This is why the CLI returned an empty result even for ASCII HTML.Verification
python -m markitdown -x htmlproduces# Test HTMLgit diff --checkpassThe only native-Windows full-suite failure is the pre-existing
test_file_urisassertion, which expects the Unix path/path/to/file.txtinstead of WindowsC:\path\to\file.txt.