Repository navigation
[Converters] Modernize YouTubeTranscriptApi static method calls - #2339
Closed
Morad Moqbel (MoradMoqbel) wants to merge 1 commit into
Closed
Morad Moqbel (MoradMoqbel) wants to merge 1 commit into
Morad Moqbel (MoradMoqbel) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
Thank you for taking the time to review the YouTube converter's API usage and propose an update. #2407, included in v0.1.8, selects Closing this PR because the proposed migration is incompatible with the supported dependencies. Please reopen it if there is still a relevant API compatibility problem, with a reproduction and an updated approach compatible with the selected versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⚡ Autonomous API Migration by ApiPatch
This automated Pull Request modernizes deprecated or breaking bs4, youtube_transcript_api API signatures across 1 file(s).
🔍 Detected Breaking Changes & Fixes:
packages/markitdown/src/markitdown/converters/_youtube_converter.pybs4.BeautifulSoup(..., from_encoding=...)bs4.BeautifulSoup(..., encoding=...)packages/markitdown/src/markitdown/converters/_youtube_converter.pyYouTubeTranscriptApi()YouTubeTranscriptApi (static class)packages/markitdown/src/markitdown/converters/_youtube_converter.pyytt_api.list(video_id)YouTubeTranscriptApi.list_transcripts(video_id)packages/markitdown/src/markitdown/converters/_youtube_converter.pyytt_api.fetch(video_id, languages=...)transcript_obj.fetch()packages/markitdown/src/markitdown/converters/_youtube_converter.pypart.text (from fetch result)part['text']packages/markitdown/src/markitdown/converters/_youtube_converter.pypart.text (from translated fetch result)part['text']🛡️ Safety & Quality Verification:
Generated autonomously with ❤️ by ApiPatch — The Autonomous AI Agent for Breaking API Changes.