Repository navigation
fix(ipynb): catch decoding exceptions in accepts() to prevent pipeline crashes on non-decodable application/json files - #2185
Closed
aoright (aoright) wants to merge 4 commits into
Closed
aoright (aoright) wants to merge 4 commits into
aoright (aoright) wants to merge 4 commits into
Conversation
…e crashes on non-decodable application/json files Signed-off-by: 辰言 <oncwnuIWp30GguOyJ615Fqj8H-yc@git.weixin.qq.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The added handler and test are behaviorally redundant with the existing broad exception handler.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Attempts to prevent notebook detection from crashing on undecodable JSON-like streams.
Changes:
- Adds explicit decoding exception handling.
- Adds a regression test for invalid UTF-8 bytes.
File summaries
| File | Description |
|---|---|
_ipynb_converter.py |
Adds targeted decoding exception handling. |
test_module_misc.py |
Tests rejection of undecodable input. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Member
|
aoright (@aoright) please respond to microsoft-github-policy-service, above |
Member
|
IpynbConverter.accepts() now safely rejects undecodable JSON through #1929. I’m closing this as superseded. Please reopen if a decoding exception still escapes on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1894.
When converting files whose MIME type starts with
application/jsonbut contain non-ASCII/binary data (such as a French PDF containing UTF-8 characters that failed to decode using the system's default locale/ASCII codec, or other binary files),IpynbConverter.accepts()raises aUnicodeDecodeErrororValueErrorwhich propagates uncaught and crashes the entire conversion pipeline.This PR wraps the
decode()operation inIpynbConverter.accepts()inside atry/except (UnicodeDecodeError, ValueError, LookupError)block, returningFalsegracefully when the file is not decodable, instead of raising an exception.Verification
test_ipynb_converter_accepts_handling_decode_errortopackages/markitdown/tests/test_module_misc.py.