Repository navigation
Preserve percent-encoded octets in href paths - #2173
Merged
Adam Fourney (afourney) merged 2 commits intoSep 2, 2026
Merged
Adam Fourney (afourney) merged 2 commits into
Adam Fourney (afourney) merged 2 commits into
Conversation
motorola g22 (ericsondea-collab)
left a comment
motorola g22 (ericsondea-collab)
left a comment
There was a problem hiding this comment.
erejnfnoejjrejnffiwojirkn
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation resolves the reported corruption and is covered by relevant regression and compatibility tests.
Pull request overview
Preserves valid percent-encoded URL path octets during HTML-to-Markdown conversion, preventing non-UTF-8 URL corruption.
Changes:
- Adds path quoting that preserves valid
%HHsequences. - Adds regression coverage for encoded octets and escaping compatibility.
File summaries
| File | Description |
|---|---|
packages/markitdown/src/markitdown/converters/_markdownify.py |
Preserves encoded path octets while quoting other characters. |
packages/markitdown/tests/test_html_converter.py |
Tests non-UTF-8 paths and URL escaping behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%HHoctets in href paths without decoding them as UTF-8Fixes #2171
Testing
test_html_converter.py: 6 passed on Python 3.10, 3.11, and 3.12