Repository navigation
fix(ocr): emit valid Markdown newlines for PPTX conversion - #2011
Closed
Leonardo Montemurro (MontesanoDev) wants to merge 1 commit into
Closed
Leonardo Montemurro (MontesanoDev) wants to merge 1 commit into
Leonardo Montemurro (MontesanoDev) wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Member
|
Thank you for contributing the newline and caption-import fixes, including the regression tests. #2506, included in v0.1.8, replaced the duplicated PPTX OCR conversion paths with the core presentation pipeline. This addresses both the literal backslash-n formatting and the incorrect caption-module import; the current formatting and caption regressions pass. Closing this PR as superseded. Please use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2010
Summary
PptxConverterWithOCRemitted literal\nsequences instead of actual line breaks in Markdown output.The optional LLM caption path also imported
llm_captionfrom a module that does not exist in themarkitdown_ocrpackage.Changes
\nsequences with actual newlines in PPTX Markdown output.llm_captionfrommarkitdown.converters._llm_caption.Testing