You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
OCR XLSX converter still fails on legacy showZeroes sheet views #2400
XlsxConverterWithOCR still fails on legacy workbooks whose worksheet view uses the historical showZeroes attribute, even though the core XLSX converter was fixed for this in #2064.
The OCR converter calls pandas.read_excel(..., engine="openpyxl") / load_workbook() directly and does not run the core converter's scoped showZeroes -> showZeros repair first.
Reproduction on current main
I built the same malformed worksheet shape covered by test_xlsx_legacy_show_zeroes_sheetview: a normal workbook whose xl/worksheets/sheet1.xml contains:
<sheetViewshowZeroes="0" ...>
Local result against the current source packages:
core: ## Data | | hello | world | | | --- | --- |
ocr error: TypeError "SheetView.__init__() got an unexpected keyword argument 'showZeroes'"
So enabling the OCR plugin reintroduces a workbook compatibility failure that the normal converter now handles.
Proposed scope
If this is available to take, I can submit a focused OCR-side follow-up that reuses the same narrowly-scoped worksheet repair before openpyxl/pandas parses the workbook, plus a regression test derived from the existing core test. I would avoid broad XLSX refactoring.
I searched current PRs/issues for an OCR-specific showZeroes fix and found no matching implementation.
AI-assisted audit disclosure: found by comparing recent merged core fixes against sibling OCR converters; reproduction was executed locally against current source.
Thank you for the detailed report and reproduction.
This is addressed by #2506, included in v0.1.8. The XLSX OCR converter now reuses the core conversion pipeline, including the scoped showZeroes workbook repair. The OCR regression for legacy sheet views passes against v0.1.8.
Please upgrade both markitdown to 0.1.8 and markitdown-ocr to 0.1.1. Closing as fixed. Please reopen this issue if the problem still occurs with those versions, and include a reproduction so we can investigate.
Activity
afourney commentedon Sep 30, 2026
Thank you for the detailed report and reproduction.
This is addressed by #2506, included in v0.1.8. The XLSX OCR converter now reuses the core conversion pipeline, including the scoped
showZeroesworkbook repair. The OCR regression for legacy sheet views passes against v0.1.8.Please upgrade both
markitdownto0.1.8andmarkitdown-ocrto0.1.1. Closing as fixed. Please reopen this issue if the problem still occurs with those versions, and include a reproduction so we can investigate.