Skip to content

OCR XLSX converter still fails on legacy showZeroes sheet views #2400

Closed

Description

@keeltrace

Summary

XlsxConverterWithOCR still fails on legacy workbooks whose worksheet view uses the historical showZeroes attribute, even though the core XLSX converter was fixed for this in #2064.

The OCR converter calls pandas.read_excel(..., engine="openpyxl") / load_workbook() directly and does not run the core converter's scoped showZeroes -> showZeros repair first.

Reproduction on current main

I built the same malformed worksheet shape covered by test_xlsx_legacy_show_zeroes_sheetview: a normal workbook whose xl/worksheets/sheet1.xml contains:

<sheetView showZeroes="0" ...>

Local result against the current source packages:

core: ## Data | | hello | world | | | --- | --- |
ocr error: TypeError "SheetView.__init__() got an unexpected keyword argument 'showZeroes'"

So enabling the OCR plugin reintroduces a workbook compatibility failure that the normal converter now handles.

Proposed scope

If this is available to take, I can submit a focused OCR-side follow-up that reuses the same narrowly-scoped worksheet repair before openpyxl/pandas parses the workbook, plus a regression test derived from the existing core test. I would avoid broad XLSX refactoring.

I searched current PRs/issues for an OCR-specific showZeroes fix and found no matching implementation.

AI-assisted audit disclosure: found by comparing recent merged core fixes against sibling OCR converters; reproduction was executed locally against current source.

Activity

  1. afourney commented on Sep 30, 2026

    @afourney
    Member

    Thank you for the detailed report and reproduction.

    This is addressed by #2506, included in v0.1.8. The XLSX OCR converter now reuses the core conversion pipeline, including the scoped showZeroes workbook repair. The OCR regression for legacy sheet views passes against v0.1.8.

    Please upgrade both markitdown to 0.1.8 and markitdown-ocr to 0.1.1. Closing as fixed. Please reopen this issue if the problem still occurs with those versions, and include a reproduction so we can investigate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions