Repository navigation
Run the broker in the container's network namespace on Linux - #1870
Merged
Merged
Conversation
Contributor
Author
|
This PR assumes that the Linux userland broker will not create/join a host network namespace. If the broker plans to do that, better to expose and use its CLI option instead of relying on the inheritance. |
Sangho Lee (sangho2)
force-pushed
the
sanghle/ulitebox/shim_netns
branch
from
November 13, 2026 02:06
72ddb1f to
3f56676
Compare
|
🤖 SemverChecks 🤖 No breaking API changes detected Note: this does not mean API is unchanged, or even that there are no breaking changes; simply, none of the detections triggered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR runs the broker in the container's network namespace on Linux. Currently, the containerd-shim ignores a network namespace's path and refuses a new network namespace, so the broker always uses the containerd-shim's network. This PR makes the guardian join the specified namespace or creates a new one before starting the broker, supporting CNI-configured networks.