Repository navigation
[DO NOT MERGE] Reproduce reset placeholder test flake - #2142
Closed
Tyrie Vella (tyrielv) wants to merge 4 commits into
Closed
Tyrie Vella (tyrielv) wants to merge 4 commits into
Tyrie Vella (tyrielv) wants to merge 4 commits into
Conversation
Exempt worktree list without relaxing locks for other worktree subcommands. Also exempt audited history, ref-query, object-statistics, and verification operations. Default annotate follows the existing blame policy for working-tree reads. Neither command provides snapshot isolation. Share the hook policy with unit coverage through a partial source file. Add deterministic first-open coverage during a paused worktree-list command. Cover read-only commands under contention and preserve normal status waits. Keep test lock holders alive only for the synchronous test action. Require lock readiness before the action and cover retained dispatcher waits. Use producer-shaped pre-command and post-command metadata in the unit cases. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Separate NUnit discovery from the exact case filter. Reuse unchanged build artifacts for the baseline. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
Use the three existing working-tree modes to restore concurrent fixture pressure without unrelated functional tests. Assisted-by: GPT-6.1 Sol Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and Context
Run 39628260944 failed on x64 in the reset placeholder test. The arm64 run passed.
The test helper reported that
git reset --stdindid not exit within 10 seconds. The Git trace records a successful exit after 17.8 seconds.This diagnostic branch starts from #2138 to retain the original code context. Do not merge this PR.
Changes
BlocksPlaceholderCreationWhileGitCommandIsRunning("reset --stdin")in the existingNone,Full, andSparseModefixtures.Reproduction Evidence
The isolated baseline passed 50 of 50 x64 attempts and 50 of 50 arm64 attempts.
The concurrent baseline passed all 300 target attempts:
NoneFullSparseModeThe local
Fullreset case also passed with Git 2.55. A separate Git 2.56 attempt stopped at a test-service startup timeout.The original failure came from the helper's 10-second cleanup deadline, not a placeholder assertion. Git exited successfully after 17.8 seconds.
The cause of that delay remains unknown. These unchanged-code samples do not reproduce the timeout, so they cannot establish a fix or a reduced failure rate.