Repository navigation
Conversation
GlidingRowsLongTable passed inline onToggle, getRowKey and renderExpanded, which are memo inputs of the expansion plugin. Every render of the story made a new plugin, so every row of the 2,000-row table rendered again, and a measurement of the story counted the story's own renders as Table's work. The story now passes a useCallback toggle and module-level helpers.
The Gliding Rows Long Table story renders 250, 500, 1,000 or 2,000 rows (default 2,000), so a cost that grows with the table's size, such as the glide's first-frame stall on iOS, can be measured at each size. Story only.
… keeps its indent
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
AI review status for this pull request.
|
Contributor
PR Analysis Report
Generated by PR Enrichment workflow | View current CI run |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maintainer impact
Intended invariant
rowscontrol picks 250, 500, 1,000 or 2,000.Change
apps/storybook/stories/TableRowExpansion.stories.tsx,GlidingRowsLongTableonly:rowsarg (default 2,000) with a select control;rowsorders, memoized onrows.Evidence
&args=rows:250(or 500, 1000) renders that many rows.Scope
Components: Table (story only)
Testing
Overlap checked: #13181 (this is stacked on it: #13181 gives the story stable callbacks and is approved in the merge line; this adds a separate rows control for a measurement the Specification session asked for, which would widen #13181 if folded in)