Skip to content

story(TableRowExpansion): the long-table story takes a rows control - #13410

Draft
cixzhang wants to merge 5 commits into
mainfrom
l0/table-long-story-rows
Draft

cixzhang wants to merge 5 commits into
mainfrom
l0/table-long-story-rows

Conversation

@cixzhang

Copy link
Copy Markdown
Contributor

Maintainer impact

  • Who: anyone measuring how Table row expansion behaves as a table grows, for example the iOS Safari stall after the glide's first frame on the 2,000-row story.
  • Problem: "Gliding Rows Long Table" always renders 2,000 rows. A measurement that needs the size at which a cost starts (rows rendered, DOM node count) needs the same story at several sizes.

Intended invariant

  • The story renders 2,000 rows by default, as today. A rows control picks 250, 500, 1,000 or 2,000.
  • Table's behavior does not change.

Change

Evidence

  • Default unchanged: with no args, the story renders the same 2,000 rows and panels as before.
  • The control: &args=rows:250 (or 500, 1000) renders that many rows.

Scope

Components: Table (story only)

  • No intended public API, product behavior, visual direction, or policy change.
  • Product changes discovered during the work were removed or split.
  • Public text and artifacts contain no internal Meta context.

Testing

  • Prettier and eslint pass on the story.

Overlap checked: #13181 (this is stacked on it: #13181 gives the story stable callbacks and is approved in the merge line; this adds a separate rows control for a measurement the Specification session asked for, which would widen #13181 if folded in)

GlidingRowsLongTable passed inline onToggle, getRowKey and renderExpanded,
which are memo inputs of the expansion plugin. Every render of the story
made a new plugin, so every row of the 2,000-row table rendered again, and
a measurement of the story counted the story's own renders as Table's work.
The story now passes a useCallback toggle and module-level helpers.
The Gliding Rows Long Table story renders 250, 500, 1,000 or 2,000 rows
(default 2,000), so a cost that grows with the table's size, such as the
glide's first-frame stall on iOS, can be measured at each size. Story only.
@cixzhang cixzhang added the lane:0 Astryx fix-loop lane 0 owns this label Nov 21, 2026
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 21, 2026 4:56pm UTC

Request Review

@astracat-bot

astracat-bot Bot commented Nov 21, 2026

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 21, 2026, 4:46 PM UTC

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

Current run: The current CI run concluded skipped. Current analysis is unavailable.


Generated by PR Enrichment workflow | View current CI run

This branch was successfully deployed

1 active deployment
Preview — 38892a4c Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. lane:0 Astryx fix-loop lane 0 owns this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant