Skip to content

chore: land 1 reviewed pull request (batch 146) - #13384

Open
josephfarina wants to merge 2 commits into
mainfrom
josephfarina/land-batch-146
Open

josephfarina wants to merge 2 commits into
mainfrom
josephfarina/land-batch-146

Conversation

@josephfarina

Copy link
Copy Markdown
Contributor

This pull request lands 1 reviewed pull request in one CI run. It was reviewed and approved on its own head.

It changes no records.

Scope

When this merges, each pull request above is closed with a note that names this one.

@josephfarina josephfarina added the merge-batch Batch of approved pull requests landed together label Nov 21, 2026
@josephfarina

Copy link
Copy Markdown
Contributor Author

/approve-spec bae8831

@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 21, 2026 3:59pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 21, 2026
@astracat-bot

astracat-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🟢 Reviewed (for maintainers only) Nov 21, 2026, 4:02 PM UTC

@github-actions

Copy link
Copy Markdown
Contributor

PR Analysis Report

🔎 Preview · bae8831

Storybook · Sandbox · built from this PR's head

Current run: Heavy CI deferred: runs when review passes and before merge. Lint, typecheck and any path-filtered checks ran on this push.


Generated by PR Enrichment workflow | View current CI run

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI: the heavy CI jobs have not run on this head yet.

This lands #13371 unchanged: Chart's curve guidance becomes a Do item that leads with the rule (keep the default straight segments of line() and area() for measured data), and the curve doc comment on both marks says the same. It changes no API, default, behavior or record, and the marks and Chart tests pass.

Claims and files checked

Review mode: full; reason: no-earlier-review

  • Claim: lands one reviewed pull request, #13371, in one CI run — verified: the head is a clean merge of #13371's head, and its diff is identical to #13371's own.
  • Claim: #13371 was reviewed and approved on its own head — verified: an approving review at #13371's head.
  • Claim: changes no records — verified: no knowledge record or spec file changes.
  • Claim: the scope is Chart in the charts package — verified: all three files are under packages/charts/src.
  • Claim: each listed pull request is closed with a note when this merges — a merge-time process step, not checkable in the repository.
  • Claim (from #13371): the curve item becomes a Do that states the rule first — verified in Chart.doc.mjs and in the CLI's best-practices output.
  • Claim (from #13371): the curve comment says measured data keeps the straight default and that 'monotone' and 'natural' smooth — verified against the curve map and the 'linear' default in both marks.
  • Claim (from #13371): the other Do and Don't items are unchanged — verified.
  • File: packages/charts/src/Chart.doc.mjs — clear.
  • File: packages/charts/src/marks/area.tsx — clear.
  • File: packages/charts/src/marks/line.tsx — clear.

Automated review (maintainer link)

This branch was successfully deployed

1 active deployment
Preview — bae8831a Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot. merge-batch Batch of approved pull requests landed together

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant