Repository navigation
chore: land 1 reviewed pull request (batch 146) - #13384
josephfarina wants to merge 2 commits into
Conversation
…ule; the curve option says so [skip ci]
…stated as a rule
|
/approve-spec bae8831 |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
PR Analysis Report🔎 Preview ·
|
There was a problem hiding this comment.
Approved pending CI: the heavy CI jobs have not run on this head yet.
This lands #13371 unchanged: Chart's curve guidance becomes a Do item that leads with the rule (keep the default straight segments of line() and area() for measured data), and the curve doc comment on both marks says the same. It changes no API, default, behavior or record, and the marks and Chart tests pass.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: lands one reviewed pull request, #13371, in one CI run — verified: the head is a clean merge of #13371's head, and its diff is identical to #13371's own.
- Claim: #13371 was reviewed and approved on its own head — verified: an approving review at #13371's head.
- Claim: changes no records — verified: no knowledge record or spec file changes.
- Claim: the scope is Chart in the charts package — verified: all three files are under
packages/charts/src. - Claim: each listed pull request is closed with a note when this merges — a merge-time process step, not checkable in the repository.
- Claim (from #13371): the curve item becomes a Do that states the rule first — verified in
Chart.doc.mjsand in the CLI's best-practices output. - Claim (from #13371): the
curvecomment says measured data keeps the straight default and that'monotone'and'natural'smooth — verified against the curve map and the'linear'default in both marks. - Claim (from #13371): the other Do and Don't items are unchanged — verified.
- File:
packages/charts/src/Chart.doc.mjs— clear. - File:
packages/charts/src/marks/area.tsx— clear. - File:
packages/charts/src/marks/line.tsx— clear.
This pull request lands 1 reviewed pull request in one CI run. It was reviewed and approved on its own head.
It changes no records.
Scope
When this merges, each pull request above is closed with a note that names this one.