Skip to content

Move alerts off the goal overview reports carrying idGoal=0 - #298

Merged
sgiehl merged 3 commits into
6.x-devfrom
id-297
Oct 28, 2026
Merged

sgiehl merged 3 commits into
6.x-devfrom
id-297

Conversation

@mneudert

Copy link
Copy Markdown
Member

Related to matomo-org/matomo#25376

The goal overview reports carrying idGoal=0 (Goals_get_idGoal--0, Goals_getVisitsUntilConversion_idGoal--0 and Goals_getDaysToConversion_idGoal--0) are retired. Goals_get_idGoal--0 reported ecommerce order figures under a goals overview name. This moves existing alerts off those reports and stops new alerts from using them.

The 6.0.1 update moves Goals_get_idGoal--0 alerts to the ecommerce order report where every site of the alert has ecommerce enabled, and to the all-goals report Goals_get otherwise. The two conversion distributions move to their all-goals reports. An alert covering sites both with and without ecommerce is therefore evaluated on all-goals figures for every site. Some of those sites were evaluated on ecommerce order figures before. Triggered alerts keep the report they were triggered for. The update only runs its migrations when an alert still uses one of these reports.

The move depends only on the sites' ecommerce setting, not on whether the Ecommerce plugin is active during the update. While that plugin is inactive, an alert moved to the ecommerce order report is not evaluated until the plugin is activated again.

For backward compatibility, CustomAlerts.addAlert and CustomAlerts.editAlert requests that still pass one of these reports resolve it the same way. The mapping mirrors core's ProcessedReport::RENAMED_REPORT_UNIQUE_IDS, which not every supported Matomo 6 release has. As a result, such a request is rejected while the Ecommerce plugin is inactive and every site of the alert has ecommerce enabled. The edit form also hides these reports, because older Matomo 6 releases still list them.

Checklist

  • [✔] Tested locally or on demo2/demo3?
  • [✔] New test case added/updated?
  • [NA] Are all newly added texts included via translation?
  • [NA] Are text sanitized properly? (Eg use of v-text v/s v-html for vue)
  • [✔] Version bumped?
  • [✔] I have understood, reviewed, and tested all AI outputs before use
  • [✔] All AI instructions respect security, IP, and privacy rules
  • [NA] Documentation updated?

@mneudert
mneudert marked this pull request as ready for review October 28, 2026 16:12
@sgiehl
sgiehl merged commit 78e9e09 into 6.x-dev Oct 28, 2026
23 checks passed
@sgiehl
sgiehl deleted the id-297 branch October 28, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants