Repository navigation
Conversation
mneudert
marked this pull request as ready for review
October 28, 2026 16:12
sgiehl
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to matomo-org/matomo#25376
The goal overview reports carrying
idGoal=0(Goals_get_idGoal--0,Goals_getVisitsUntilConversion_idGoal--0andGoals_getDaysToConversion_idGoal--0) are retired.Goals_get_idGoal--0reported ecommerce order figures under a goals overview name. This moves existing alerts off those reports and stops new alerts from using them.The
6.0.1update movesGoals_get_idGoal--0alerts to the ecommerce order report where every site of the alert has ecommerce enabled, and to the all-goals reportGoals_getotherwise. The two conversion distributions move to their all-goals reports. An alert covering sites both with and without ecommerce is therefore evaluated on all-goals figures for every site. Some of those sites were evaluated on ecommerce order figures before. Triggered alerts keep the report they were triggered for. The update only runs its migrations when an alert still uses one of these reports.The move depends only on the sites' ecommerce setting, not on whether the Ecommerce plugin is active during the update. While that plugin is inactive, an alert moved to the ecommerce order report is not evaluated until the plugin is activated again.
For backward compatibility,
CustomAlerts.addAlertandCustomAlerts.editAlertrequests that still pass one of these reports resolve it the same way. The mapping mirrors core'sProcessedReport::RENAMED_REPORT_UNIQUE_IDS, which not every supported Matomo 6 release has. As a result, such a request is rejected while the Ecommerce plugin is inactive and every site of the alert has ecommerce enabled. The edit form also hides these reports, because older Matomo 6 releases still list them.Checklist