feat: Honour postgresql_version on SUSE and handle transactional updates

README.md

@@ -24,6 +24,7 @@ ansible-galaxy collection install -vv -r meta/collection-requirements.yml
 ### postgresql_version
 
 You can set the version of the PostgreSQL server to 10, 12, 13, 15, 16 or 18.
+On SUSE, it can be set to 16, 17 or 18, and the default is 18.
 
 ```yaml
 postgresql_version: "13"
@@ -164,6 +165,22 @@ logs, so it should only be used in development or troubleshooting scenarios.
 
 Default: `true`
 
+### postgresql_transactional_update_reboot_ok
+
+This variable is used to handle reboots required by transactional updates. If a
+transactional update requires a reboot, the role will proceed with the reboot if
+`postgresql_transactional_update_reboot_ok` is set to `true`. If set to `false`, the
+role will notify the user that a reboot is required, allowing for custom
+handling of the reboot requirement. If this variable is not set, the role will
+fail to ensure the reboot requirement is not overlooked. For non-transactional
+update systems, this variable is ignored.
+
+```yaml
+postgresql_transactional_update_reboot_ok: true
+```
+
+Default: `null`
+
 ## Idempotence
 
 This section should cover role behavior for repeated runs.

defaults/main.yml

@@ -22,4 +22,7 @@ postgresql_ssl_enable: false
 postgresql_certificates: []
 postgresql_secure_logging: true
 
+# Transactional update reboot: true reboots, false only notifies, null fails
+postgresql_transactional_update_reboot_ok: null
+
 __postgresql_write_log_file: false

meta/argument_specs.yml

@@ -193,3 +193,13 @@ argument_specs:
         description: >
           Whether to suppress logging of sensitive commands such as
           password changes. Set to `false` for troubleshooting.
+      postgresql_transactional_update_reboot_ok:
+        type: raw
+        default: null
+        description: >
+          Whether to permit reboots required by transactional updates. Set
+          to `true` to allow reboots, `false` to disallow reboots, or
+          leave unset so that the role will fail to ensure the reboot
+          requirement is not overlooked. Accepts a boolean value or `null`.
+          Only managed nodes whose OS uses transactional updates read it;
+          on other systems it is ignored.

meta/main.yml

@@ -23,4 +23,6 @@ galaxy_info:
     - fedora
     - leap
     - postgresql
+    - sles
+    - sles16
 dependencies: []

tasks/assert_role_vars.yml

@@ -120,3 +120,14 @@
     index_var: idx
     label: "{{ item.name | d('unnamed') }}"
   when: item.mode is defined
+
+- name: Assert postgresql_transactional_update_reboot_ok is null or a boolean
+  ansible.builtin.assert:
+    that:
+      - >-
+        (postgresql_transactional_update_reboot_ok is none)
+        or (postgresql_transactional_update_reboot_ok is sameas true)
+        or (postgresql_transactional_update_reboot_ok is sameas false)
+    fail_msg: >-
+      postgresql_transactional_update_reboot_ok must be null or a boolean,
+      got {{ postgresql_transactional_update_reboot_ok | type_debug }}

tasks/main.yml

@@ -42,11 +42,15 @@
   fail:
     msg: >-
       Setting version {{ __postgresql_version }} while
-      {{ ansible_facts.packages['postgresql'][0].version }} is installed
+      {{ __installed_versions | join(', ') }} is installed
   when:
-    - "'postgresql' in ansible_facts.packages"
-    - ansible_facts.packages["postgresql"][0].version |
-      regex_search('([0-9]*).', '\\1') | first != __postgresql_version | string
+    - __installed_versions | length > 0
+    - __installed_versions != [__postgresql_version | string]
+  vars:
+    __installed_versions: "{{ ansible_facts.packages | dict2items |
+      selectattr('key', 'match', __postgresql_version_packages) |
+      map(attribute='value') | flatten | map(attribute='version') |
+      map('regex_search', '^([0-9]+)', '\\1') | map('first') | unique | list }}"
 
 # rpm ostree pkg mgr cannot handle @groups/modules
 # so just assume the packages are present
@@ -62,6 +66,42 @@
       (__postgresql_is_ostree | d(false)) |
       ternary(__postgresql_packages | reject('match', '^@'),
               __postgresql_packages) | list }}"
+  register: __postgresql_package_result
+
+# A staged install reports ok on re-runs, so ask rpm (by provides) if it is live.
+- name: Check whether the packages are live on a transactional update system
+  command:  # noqa command-instead-of-module
+    argv: "{{ ['rpm', '-q', '--whatprovides'] + __postgresql_packages }}"
+  register: __postgresql_packages_live
+  changed_when: false
+  failed_when: false
+  check_mode: false
+  when: __postgresql_is_transactional
+
+- name: Handle reboot for transactional update systems
+  when:
+    - __postgresql_is_transactional
+    - __postgresql_package_result is changed or
+      (__postgresql_packages_live.rc | d(0)) != 0
+  block:
+    - name: Notify user that reboot is needed to apply changes
+      debug:
+        msg: >
+          Reboot required to apply changes due to transactional updates.
+
+    - name: Reboot transactional update systems
+      reboot:
+        msg: Rebooting the system to apply transactional update changes.
+      when:
+        - postgresql_transactional_update_reboot_ok is not none
+        - postgresql_transactional_update_reboot_ok | bool
+
+    - name: Fail if reboot is needed and not set
+      fail:
+        msg: >
+          Reboot is required but not allowed. Please set 'postgresql_transactional_update_reboot_ok' to proceed.
+      when:
+        - postgresql_transactional_update_reboot_ok is none
 
 - name: Init DB on booted systems (with postgresql-setup)
   when:

tasks/set_vars.yml

@@ -10,6 +10,7 @@
     __postgresql_version_default: "{{ '16' if ansible_facts['os_family'] == 'RedHat'
       and ansible_facts['distribution'] != 'Fedora'
       and ansible_facts['distribution_major_version'] == '10'
+      else '18' if ansible_facts['os_family'] == 'Suse'
       else '13' }}"
     __postgresql_server_tuning_default: "{{ false if (ansible_connection | d('')) == 'buildah' else true }}"
 
@@ -43,6 +44,18 @@
       set_fact:
         __postgresql_is_ostree: "{{ __ostree_booted_stat.stat.exists }}"
 
+- name: Determine if system is transactional update and set flag
+  when: __postgresql_is_transactional is not defined
+  block:
+    - name: Check if transactional-update exists in /sbin
+      stat:
+        path: /sbin/transactional-update
+      register: __transactional_update_stat
+
+    - name: Set flag if transactional-update exists
+      set_fact:
+        __postgresql_is_transactional: "{{ __transactional_update_stat.stat.exists }}"
+
 - name: Determine if system is booted with systemd
   when: __postgresql_is_booted is not defined
   block:

tests/tests_versions.yml

@@ -5,8 +5,10 @@
   tasks:
     - name: Skip test if distro does not support multiple versions
       meta: end_host
-      when: ansible_facts['distribution'] not in ['CentOS', 'RedHat'] or
-        ansible_facts['distribution_major_version'] not in ["8", "9", "10"]
+      when:
+        - ansible_facts['distribution'] not in ['CentOS', 'RedHat'] or
+          ansible_facts['distribution_major_version'] not in ["8", "9", "10"]
+        - ansible_facts['os_family'] != 'Suse'
 
     - name: Install and cleanup default version
       include_tasks: tasks/install_and_check.yml
@@ -28,7 +30,9 @@
       vars:
         __test_check_version: true
         postgresql_version: "{{ item }}"
-        __versions: "{{ __postgresql_versions_el8
+        __versions: "{{ __postgresql_versions_suse
+          if ansible_facts['os_family'] == 'Suse'
+          else __postgresql_versions_el8
           if ansible_facts['distribution_major_version'] == '8'
           else __postgresql_versions_el9
           if ansible_facts['distribution_major_version'] == '9'

vars/Suse.yml

@@ -2,6 +2,9 @@
 ---
 # SUSE-specific variables
 # SUSE does not have postgresql-setup, initdb is called directly
-__postgresql_packages: [postgresql-server]
+# SUSE ships each major version as its own package, so install the requested one
+__postgresql_packages: ["postgresql{{ __postgresql_version }}-server"]
+__postgresql_version_packages: "^postgresql[0-9]+-server$"
+__postgresql_versions_suse: ["16", "17", "18"]
 __postgresql_has_setup_cmd: false
 __postgresql_cert_directory: /etc/ssl

vars/main.yml

@@ -6,6 +6,8 @@
 
 # Examples of non-distribution specific (generic) internal variables:
 __postgresql_packages: [postgresql-server]
+# installed packages whose version is the server's major version
+__postgresql_version_packages: "^postgresql$"
 __postgresql_versions_el8: ["10", "12", "13", "15", "16"]
 __postgresql_versions_el9: ["13", "15", "16", "18"]
 __postgresql_versions_el10: ["16", "18"]