Skip to content

Unify HF search UX and add detail panel for HF models (#2564) - #2700

Merged
fl0rianr merged 1 commit into
kpoin/ui-testingfrom
kpoin/2564-hf-search-visible
Jul 14, 2026
Merged

fl0rianr merged 1 commit into
kpoin/ui-testingfrom
kpoin/2564-hf-search-visible

Conversation

@kpoineal

Copy link
Copy Markdown
Collaborator

Unifies the HuggingFace search experience on the Models page and adds detail panel support for HF results.

Changes:

  • Removed dead compact HF rendering path that showed degraded rows with non-functional clicks (double rendering bug)
  • HF search results now use rich zone cards as the single rendering path
  • Clicking an HF result opens the right-pane ModelDetailPanel with an HF-specific view: repo metadata, downloads/likes, tags, variant picker with download buttons, and a README tab fetched from HuggingFace
  • Added close button (x) to ModelDetailPanel top-right corner (works for both local and HF models, touch-friendly)
  • Removed HuggingFace entry from nav rail (was a dead-end filter)
  • HF zone auto-elevates to top of list when no local models match the search query

Addresses #2564

Tests: 201 passed / 9 skipped — zero regressions

- Remove dead compact HF rendering path (hfModelInfos/hfMode) that showed
  degraded rows with non-functional clicks
- Keep rich HF zone cards as the single rendering path for search results
- Clicking an HF result now opens the right-pane ModelDetailPanel with an
  HF-specific view: repo metadata, variant picker, README tab
- Add close button (x) to ModelDetailPanel for dismissing the right pane
- Remove HuggingFace entry from nav rail (was a dead-end filter)
- Elevate HF zone to top when no local models match the search query

Addresses #2564

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added the app label Jul 14, 2026

@fl0rianr fl0rianr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fl0rianr
fl0rianr merged commit d1b861d into kpoin/ui-testing Jul 14, 2026
66 checks passed
@fl0rianr
fl0rianr deleted the kpoin/2564-hf-search-visible branch July 14, 2026 15:50
pwilkin added a commit to pwilkin/lemonade that referenced this pull request Jul 16, 2026
…, candidate list, server scope) and reconcile HF UX with kpoin

- available-memory: apply GiB→MiB before the 1024 floor so a 64 GB box isn't
  treated as ~1 TiB; move availableMib into synthesize and unit-test 16/64/128 GB
- fallback ctx: record the context that actually loaded via distinct fallback
  keys and cap the recommendation to it (a failed heuristic ctx no longer wins)
- candidates: one shared selectCandidates() for controller + synthesize; CPU-only
  systems are rejected instead of benchmarking CPU and recommending Vulkan
- server scope: on base-URL change stop local pollers, load the new server's
  runs, reattach only its in-flight jobs, and guard writes by scope generation
- HF UX: bring ModelList/Manager/NavRail/DetailPanel/styles + a11y specs up to
  current kpoin/ui-testing (feat was behind lemonade-sdk#2700), keeping AutoOpt edits

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018Z9WMqprhqjWEDuv1gnGaH
fl0rianr pushed a commit that referenced this pull request Jul 17, 2026
- Remove dead compact HF rendering path (hfModelInfos/hfMode) that showed
  degraded rows with non-functional clicks
- Keep rich HF zone cards as the single rendering path for search results
- Clicking an HF result now opens the right-pane ModelDetailPanel with an
  HF-specific view: repo metadata, variant picker, README tab
- Add close button (x) to ModelDetailPanel for dismissing the right pane
- Remove HuggingFace entry from nav rail (was a dead-end filter)
- Elevate HF zone to top when no local models match the search query

Addresses #2564

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants