Repository navigation
a11y(backend): keyboardable matrix, qualified actions, live toasts (#2343 #2344 #2351) - #2360
Merged
Merged
Conversation
This was referenced Jun 22, 2026
Collaborator
Author
|
Internal review: LGTM (advisory — human approval required) Authored by Mattingly; reviewed by Lovell.
|
Collaborator
Author
|
Rebased onto merged base a8718a7. Conflicts resolved in ests/a11y.spec.ts (branch's new tests renumbered to A51–A58) and ACCESSIBILITY.md (union merge). Final suite: 69 passed / 7 skipped / 0 failed. — Mattingly |
kpoineal
force-pushed
the
feat/gui3-backend-a11y
branch
from
June 23, 2026 12:58
5ea8eeb to
72279f2
Compare
This was referenced Jun 23, 2026
fl0rianr
pushed a commit
that referenced
this pull request
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three NVDA/keyboard accessibility fixes in
BackendManager.tsx(Group C of the gui3 a11y series).#2343 — Backend matrix cells are now keyboard-operable
Problem: Clickable
<div>cells in the capability matrix had no keyboard focus, no ARIA role, and no selected state — mouse-only.Fix: Applied the overlay-button pattern (same as
recipe-card__overlay-btnin PresetManager):.cell--selectablegainsposition: relative.<button class="cell__select-btn" aria-pressed aria-label>withposition: absolute; inset: 0; z-index: 0covers the full cell.aria-pressedreflects selection state ("true"/"false").aria-labelincludes the human-readable recipe label and backend identifier (e.g.,"llama.cpp (vulkan), Available")..cell__actions) getposition: relative; z-index: 1so they remain clickable above the overlay.:focus-visiblering (2px accent outline) renders on the overlay button when keyboard-focused.Closes #2343
#2344 — Backend action buttons now have qualified accessible names
Problem: Install, Update, Uninstall buttons had generic labels ("Install" / "Update" / "Uninstall") that collided across multiple backends when announced by NVDA.
Fix: Added
aria-labelto each action button containing both the recipe label and backend identifier:aria-label="Install llama.cpp (vulkan)"aria-label="Update llama.cpp (vulkan)"aria-label="Uninstall llama.cpp (cpu)"aria-label="Setup guide for ryzenai (hybrid)"Visible button text is unchanged;
aria-labeloverrides the accessible name for AT.Closes #2344
#2351 — Toast and preset notices are now live regions
Problem:
backends__toastandcontext-rail__noticewere conditionally mounted ({msg && <div>…</div>}). Mounting a node with content does not trigger NVDA live region announcements — the element must already exist in the DOM before content changes.Fix: Two always-present
<div role="status" aria-live="polite" aria-atomic="true" class="sr-only">elements added:data-backends-toast-live— mirrorstoastMsg(installing/updating/uninstalling progress and completion).data-backends-preset-notice-live— mirrorspresetNotice(preset assignment confirmations and incompatibility notices).Visual toast and notice remain conditionally rendered (no visual change). Only the sr-only live regions are always in the DOM.
Closes #2351
Tests
8 new tests added to
tests/a11y.spec.ts(A35–A42):aria-labelResult: 58 passed / 7 skipped / 0 failed (baseline was 50 passed / 7 skipped / 0 failed)
A human reviews before merge. No behavior or visual changes for mouse/pointer users.