Repository navigation
Conversation
The function only reads the xloc, yloc, zloc and edep columns, but required a TypedTables Table. LegendHDF5IO 0.2 returns the steps read with `h5["stp/..."][:]` as a StructArray, which now works as the docstring example shows. Assisted-By: generative AI
LegendDataManagement 0.7 is the release that requires LegendHDF5IO 0.2, so both bounds widen together. The tests pass with LegendHDF5IO 0.1.19 and LegendDataManagement 0.6.26 as well as with 0.2.0 and 0.7.0. Assisted-By: generative AI
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #35 +/- ##
=======================================
Coverage 46.11% 46.11%
=======================================
Files 11 11
Lines 360 360
=======================================
Hits 166 166
Misses 194 194 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
oschulz
marked this pull request as draft
November 12, 2026 10:45
Contributor
Author
|
Blocked by legend-exp/LegendDataManagement.jl#247 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Written by Claude (Anthropic) in Claude Code, a Fable 5.1 session at xhigh effort, under the guidance of @oschulz, who asked for this PR.
Allows LegendHDF5IO 0.2, released today, alongside 0.1. One code change was needed:
log_p0_nominalrequired a TypedTablesTablefor the simulation steps but only reads theirxloc,yloc,zlocandedepcolumns, and LegendHDF5IO 0.2 returnsh5["stp/..."][:]as aStructArray. The argument now accepts any table with those columns, as the docstring already described.Since LegendDataManagement 0.7 is the release that requires LegendHDF5IO 0.2, its bound widens to
"0.6.10, 0.7"at the same time. Until LegendDataManagement 0.7.0 is registered (legend-exp/LegendDataManagement.jl#247), the resolver keeps picking LegendHDF5IO 0.1.19, so CI here runs the old combination.Verified locally: all 181 tests pass with LegendHDF5IO 0.1.19 and LegendDataManagement 0.6.26, and with LegendHDF5IO 0.2.0 and LegendDataManagement 0.7.0 from its branch. Version bumped to 0.3.1 for a patch release.