Repository navigation
Run DSP without optimization parameters; filter optimization for all usable detectors - #238
Merged
Merged
Conversation
A detector without energy filter or A/E optimization parameters is processed with the default filter parameters of its DSP configuration. It fails only if its DSP configuration requires parameters for it via `required_fltopt` / `required_aoeopt` and they are missing.
`process_filter_optimization_cal` and `p_process_filter_optimization_cal` select the detectors that match `processable && usability != :off` in the shipped processing config, so detectors with usability `:ac` are optimized as well.
`p_process_skm_phy` skims the runs of a period that have a `phy` start key in the runinfo. A run without one, e.g. one whose `phy` the dataset does not list, has no `phy` data to skim.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
==========================================
+ Coverage 54.52% 54.53% +0.01%
==========================================
Files 75 75
Lines 10765 10763 -2
==========================================
Hits 5870 5870
+ Misses 4895 4893 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
process_dsp_calandprocess_dsp_phyprocess a detector without energy filter or A/E optimization parameters with the default filter parameters of its DSP configuration. Such a detector still fails if its DSP configuration lists required parameters for it (required_fltopt/required_aoeopt) and they are missing.processable && usability != :offforprocess_filter_optimization_calandp_process_filter_optimization_cal, so detectors with usability:acare optimized as well. Existing production configs are not changed.p_process_skm_physkims only the runs of a period that have aphystart key in the runinfo. A run without one, e.g. one whosephythe dataset does not list (see Restrict runinfo to the run lists of a dataset; DataSet livetimes and time selections LegendDataManagement.jl#246), has nophydata to skim.Tests
Pkg.test()passes (3489 passed). No new test covers the empty-parameter case, since it needs metadata and parameters that the test suite does not have.Parts of this pull request, including code and this description, were written with the help of generative AI.