Skip to content

fix: Measure synchronizer deadlines with a monotonic clock - #253

Merged
beekld merged 1 commit into
bklimt/SDK-3402/retry-parkingfrom
bklimt/SDK-3402/monotonic-deadlines
Nov 12, 2026
Merged

beekld merged 1 commit into
bklimt/SDK-3402/retry-parkingfrom
bklimt/SDK-3402/monotonic-deadlines

Conversation

@beekld

@beekld beekld commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The FDv2 synchronizer loop measured its deadlines against the wall clock. When the system clock stepped backwards, every pending deadline was delayed by the size of the step. If every synchronizer was parked for 5 minutes and the clock stepped back an hour, no synchronizer ran for 65 minutes.

These deadlines now use MonotonicTime, a small value class over System.nanoTime(), so changes to the system clock don't move them.

Stacked on #252.


Note

Overview
FDv2 synchronizer orchestration previously scheduled recovery, fallback, park/unpark, and FDv1 fallback TTL deadlines using wall-clock Instant. A backward system clock step could postpone those deadlines and keep sources parked or on FDv1 longer than intended.

This PR introduces MonotonicTime (backed by System.nanoTime()) and wires it through FDv2DataSource, SourceManager, and SynchronizerFactoryWithState for all internal wait/deadline logic (awaitUntil, earliest, parking, fallback end times). MonotonicTimeTest covers comparison and duration math across nanosecond counter overflow.

Reviewed by Cursor Bugbot for commit d8cd1e1. Bugbot is set up for automated code reviews on this repo. Configure here.

@beekld
beekld added this pull request to stack #254 November 6, 2026 03:27
@beekld
beekld marked this pull request as ready for review November 6, 2026 03:27
@beekld
beekld requested a review from a team as a code owner November 6, 2026 03:27
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch 2 times, most recently from 7a1fa34 to 5198a56 Compare November 6, 2026 17:37
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch 7 times, most recently from 3812f38 to 1d4190d Compare November 11, 2026 01:29
@beekld
beekld force-pushed the bklimt/SDK-3402/monotonic-deadlines branch from 1d4190d to d8cd1e1 Compare November 11, 2026 01:44
@beekld
beekld merged commit 3c7da2c into main Nov 12, 2026
56 checks passed
@beekld
beekld deleted the bklimt/SDK-3402/monotonic-deadlines branch November 12, 2026 18:42
beekld pushed a commit that referenced this pull request Nov 12, 2026
🤖 I have created a release *beep* *boop*
---


##
[7.18.0](launchdarkly-java-server-sdk-7.17.5...launchdarkly-java-server-sdk-7.18.0)
(2026-11-12)


### Features

* Apply RETRY to FDv2 synchronizer orchestration
([#252](#252))
([6a4aac5](6a4aac5))


### Bug Fixes

* Include the big segments status on evaluation reasons when a flag
fails to evaluate
([#258](#258))
([ce08ae8](ce08ae8))
* Make TestData valueForAll return its value when targeting is off
([#251](#251))
([db17ab9](db17ab9))
* Measure synchronizer deadlines with a monotonic clock
([#253](#253))
([3c7da2c](3c7da2c))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Overview**
> This **Release Please** PR cuts **launchdarkly-java-server-sdk
7.18.0** by bumping version metadata only:
`.release-please-manifest.json`, `lib/sdk/server/gradle.properties`, and
`Version.SDK_VERSION` move from **7.17.5** to **7.18.0**.
> 
> `CHANGELOG.md` gains a **7.18.0** section that records what ships in
this artifact (already merged elsewhere): **RETRY** on FDv2 synchronizer
orchestration; big-segments status on evaluation reasons when evaluation
fails; `TestData` `valueForAll` honoring its value when targeting is
off; synchronizer deadlines measured with a monotonic clock. This diff
does not contain those implementation changes.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
aa18674. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants