Skip to content

Follow-ups for #984: name every sorted result file, credit srivarshni7 (waiting on sign-off) - #1016

Draft
wshlavacek wants to merge 3 commits into
mainfrom
contrib/984-followups
Draft

wshlavacek wants to merge 3 commits into
mainfrom
contrib/984-followups

Conversation

@wshlavacek

Copy link
Copy Markdown
Collaborator

Draft. Do not merge this PR. It tracks the maintainer follow-ups to #984, and runs CI on them, while #984 waits for the contributor's sign-off (request). When the sign-off arrives, these commits go onto #984's branch and #984 is the PR that merges, so the contributor keeps the credit.

Commits

Commit Author What
6c04ed2 srivarshni7 #984, unchanged: the starting_params entry names the sorted files instead of saying "every result file" is sorted (#932)
720609a maintainer Names all three sorted files (samples.txt, sorted_params*.txt, bootstrapped_parameter_sets.txt), says the sort is case-sensitive, and says start_point pins only a sampler's first chain. Adds tests/test_result_file_parameter_order.py
1d1f8d4 maintainer Adds srivarshni7 to CONTRIBUTORS.md

When the sign-off lands

How it was checked

Refs #932, #984.

srivarshni7 and others added 3 commits October 9, 2026 13:56
… case-sensitive (#932)

The starting_params entry now lists the three files whose parameter columns
are sorted: samples.txt, sorted_params*.txt and bootstrapped_parameter_sets.txt.
The glob is sorted_params*.txt so that it also covers plain sorted_params.txt,
which is written when delete_old_files >= 2. The bootstrap file goes through
the same Trajectory writer as sorted_params, so it is sorted too.

The sort is Python's case-sensitive string order. Parameters declared kcat, Km,
alpha are written Km, alpha, kcat, so "alphabetical" would have sent a reader
looking for alpha, kcat, Km.

The entry also says that start_point is not a drop-in replacement for
starting_params on a sampler. start_point pins only the first chain, and
starting_params sets every chain.

tests/test_result_file_parameter_order.py pins every order the docs state:
- samples.txt, sorted_params_final.txt, sorted_params.txt, each
  Results-boot{N}/sorted_params.txt and bootstrapped_parameter_sets.txt are
  sorted;
- start_point.txt, the credible rows and am's params_0.txt are in
  declaration order;
- starting_params is applied in declaration order;
- continue_run = 1 overrides starting_params.
The expected orders are written out by hand. The boxes do not overlap, so a
value written under the wrong header falls outside its box.

Signed-off-by: Bill Hlavacek <bill.hlavacek@gmail.com>
Signed-off-by: Bill Hlavacek <bill.hlavacek@gmail.com>
@wshlavacek wshlavacek added gated Blocked on an external trigger, e.g. an upstream release; revisit when it fires documentation Docs are absent, stale, or state something untrue labels Nov 4, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Docs are absent, stale, or state something untrue gated Blocked on an external trigger, e.g. an upstream release; revisit when it fires

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants