Repository navigation
Synchronize JWKS cancellation tests - #215
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
micro509 | a024728 | Commit Preview URL Branch Preview URL |
Oct 30 2026, 03:45 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared-request cancellation test starts two asynchronous token-signing operations, then cancels after the first HTTP hit. That does not establish that both verifications have joined the resolver, so a legitimate second request can fail its one-request assertion under load.
Prepare the token and JWKS body before the scenario, observe both calls entering the real resolver, and hold the real HTTP response behind a promise until cancellation has been checked. Add the complementary case proving that cancellation of the sole waiter permits a later verification to start a second request. No library runtime changes.
Fixes #213. The independent stress-job setup fix is #214; both PRs target master and can merge independently.
Validation:
1599345495: 700 passed, zero failures.typecheck:other, Biome, dprint and diff checks passed.The full scheduled stress suite was not repeated locally.